1564512 - [tc-github] a .taskcluster.yml in a PR without one in the master branch is skipped

Status: RESOLVED MOVED

(Taskcluster :: Services, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster/blob/8bf75678626567ec2fdae3889dff2f6d86235958/services/github/src/handlers.js#L603-L605

    let defaultBranchYml = await this.getYml({instGithub, owner: organization, repo: repository, ref: defaultBranch});

    if (!defaultBranchYml) { return; }

This means experimenting with .taskcluster.yml in a PR silently does nothing.

Could we assume the most restrictive policy, instead?

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Owlish, what do you think?

Comment 2

[[:owlish] 🦉 PST]

What policy would you suggest (to rephrase: what would "the most restrictive" mean)? (edited upon reading the title of the bug)

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

I think "collaborators" is the most restrictive (in other words, it allows the least of all of the policy options).

Comment 4

[[:owlish] 🦉 PST]

I see, so you are suggesting: why don't we stop checking the yml in the default branch and just use "collaborators" policy always. That will deprive people of policy choice tho?

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

No, my idea is that when there is no .taskcluster.yml in the default branch, then we default to "collaborators".

Comment 6

[Johan Lorenzo [:jlorenzo]]

Hey there!

I hit that issue too, today. My main worry is that tc-github silently fails. I didn't have any feedback about the reason why no jobs were scheduled.

My STR are:

1. Enable TC on a new repo
2. Create a PR that creates .taskcluster.yml
3. See a first error because of some parsing shenanigans.
4. Fix it: No error is reported. No job is scheduled. Run json-e locally and see it output the expected result.

I was confused by this behavior, especially because tc-github did provide some early feedback at the beginning.

Comment 7

[Aki Sasaki (not active)]

(In reply to Dustin J. Mitchell [:dustin] (he/him) from comment #5)

No, my idea is that when there is no .taskcluster.yml in the default branch, then we default to "collaborators".

+1, it's tricky setting up a .taskcluster.yml for the first time in a repo that i don't own atm.

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster/issues/3927