1564518 - Recommendations message bar should have Close button

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Amy Tsay [:amyt]]

Attachment: Screenshot 2019-07-09 11.02.28.png

The Recommendations message bar on Disco Pane and the Extensions tab should give users the option to dismiss.

Comment 1

[emanuela [ux]]

Attachment: message-bar-close.png

Add a close [ x ] button next to the Learn More. Example in the attachment.

Comment 2

[Trishul]

Hey Mark, I can take this up, if you are occupied :)

Comment 3

[Mark Striemer [:mstriemer]]

Absolutely! The message-bar can have a dismissable attribute which will add the close button, we'll need to record that it's been closed somehow and avoid showing it again though. Setting a pref that it should be hidden would be a good first step I'd say, but there might be a better way of doing it.

There's also an issue where the margin is on the message-bar rather than the heading here, so when you close the message-bar there isn't enough space between the heading and the first card. Would you mind moving that margin to the header, too?

Comment 4

[Trishul]

Attachment: Bug 1564518: Recommendations message bar should have Close button

Recommendations message bar should have Close button

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5810afcd0ce
Recommendations message bar should have Close button r=mstriemer

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f5810afcd0ce

Comment 7

[Alex Cornestean]

Hello,

Verified the fix on the latest Nightly (73.0a1/20191222215627) under Windows 10 Pro 64-bit and MacOS Catalina 10.15.

The option to close the Recommendations message is present on the Disco Pane and the Extensions tab and using it will properly dismiss the message, confirming the fix.