1564538 - Launcher process: Disable compiler emission of memset/memcpy calls in DllBlocklistWin.cpp

Status: RESOLVED FIXED

(Firefox :: General, task, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

We can't assume that the code in DllBlocklistWin.cpp will have a language runtime available. This could be problematic if the compiler emits calls to memset or memcpy to initialize data structures (inlined intrinsics are still OK).

Apparently specifying -ffreestanding will inform clang of this condition.
We also need to check up on the situation for GCC.
I'm less sure about MSVC, all I could find on the subject was this StackOverflow post.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Looks like (as expected) GCC uses the same flag.

Comment 2

[(Away)]

Configure won't let you proceed with MSVC these days, so no need to worry about it.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to David Major [:dmajor] from comment #2)

Configure won't let you proceed with MSVC these days, so no need to worry about it.

Great, thanks!

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1564538: Set -ffreestanding on DllBlocklistWin.cpp; r=dmajor!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb3217bef0ec
Set -ffreestanding on DllBlocklistWin.cpp; r=dmajor

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/fb3217bef0ec