Closed Bug 1564538 Opened 5 months ago Closed 5 months ago

Launcher process: Disable compiler emission of memset/memcpy calls in DllBlocklistWin.cpp

Categories

(Firefox :: General, task, P1)

Unspecified
Windows
task

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Blocks 1 open bug)

Details

(Whiteboard: inj+)

Attachments

(1 file)

We can't assume that the code in DllBlocklistWin.cpp will have a language runtime available. This could be problematic if the compiler emits calls to memset or memcpy to initialize data structures (inlined intrinsics are still OK).

Apparently specifying -ffreestanding will inform clang of this condition.
We also need to check up on the situation for GCC.
I'm less sure about MSVC, all I could find on the subject was this StackOverflow post.

Looks like (as expected) GCC uses the same flag.

Configure won't let you proceed with MSVC these days, so no need to worry about it.

(In reply to David Major [:dmajor] from comment #2)

Configure won't let you proceed with MSVC these days, so no need to worry about it.

Great, thanks!

Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Priority: P3 → P1
See Also: → 1566550
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb3217bef0ec
Set -ffreestanding on DllBlocklistWin.cpp; r=dmajor
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.