1564549 - Replace Android JS layer with native functions

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[Eitan Isaacson [:eeejay]]

We currently our presentational code (events, accessible tree) in our native module and most of our interactive code (accessibility focus, text navigation, clipboard) in javascript.

The javascript layer is a relic from the previous mobile accessibility implementation. It has not been ported to native because it was a higher priority to get something working fast. It makes sense to complete the transition to native code for the following reasons:

1. Complexity will be reduced if the functionality will be consolidated to one module, and it will be much more accessible to newcomers.
2. Common points of reference: In javascript we don't have access to the accessible's platform virtual view id. This means that when clients want to perform actions on specific nodes we need to guess which one they want to use, like the currently focused one, or current virtual cursor position. If we migrate this to native, there will be a common point of reference as to which node is acted upon and which one emits an event.
3. Performance/memory: We will not have the additional xpc layer.
4. Removing the xpc code will allow us to have cleaner and more predictable shutdown when not in use.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Introduce platform a11y ipdl messages. r?Jamie!

This is to allow platform-specific IPC calls without polluting the
namespace for other platforms. This works nicely with wrappers.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Add action forwarding macro. r?Jamie!

Depends on D37628

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Introduce native traveral rule. r?yzen!

The rule takes a granularity constant as an argument in the constructor.

Depends on D37629

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Implement move and explore by touch natively. r?yzen!,#geckoview-reviewers!

Depends on D37630

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Implement text navigation natively. r?Jamie!,#geckoview-reviewers!

Depends on D37631

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Implement set selection natively. r?yzen!,#geckoview-reviewers!

Depends on D37632

Comment 7

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Implement clipboard actions natively. r?yzen!,#geckoview-reviewers!

Depends on D37633

Comment 8

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Remove event dispatching to dead code. r?#geckoview-reviewers!

Some of these should be implemented in the future.

Depends on D37634

Comment 9

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Handle remaining events from EventManager.jsm in AccessibleWrap. r?yzen!

Stop dispatching GeckoView::AccessibilitySettings from java. This
prevents AccessFu from activating. We'll remove it entirely in a future
patch.

Depends on D37635

Comment 10

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Remove AccessFu. r?yzen!,#geckoview-reviewers!

Depends on D37636

Comment 11

[Eitan Isaacson [:eeejay]]

I'm going to set up a blocker bug so that a11y module folks could design a good solution for platform specific ipdl calls.

Comment 12

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Add action forwarding macro. r?Jamie!

Comment 13

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Introduce native traveral rule. r?yzen!

The rule takes a granularity constant as an argument in the constructor.

Depends on D45597

Comment 14

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Implement move and explore by touch natively. r?yzen!,#geckoview-reviewers!

Depends on D45598

Comment 15

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Implement text navigation natively. r?Jamie!,#geckoview-reviewers!

Depends on D45599

Comment 16

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Implement set selection natively. r?yzen!,#geckoview-reviewers!

Depends on D45600

Comment 17

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Implement clipboard actions natively. r?yzen!,#geckoview-reviewers!

Depends on D45601

Comment 18

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Remove event dispatching to dead code. r?#geckoview-reviewers!

Some of these should be implemented in the future.

Depends on D45602

Comment 19

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1564549 - Remove AccessFu. r=yzen,snorp

Depends on D45603

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aca91e9add16
Add action forwarding macro. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/c38e72058869
Introduce native traveral rule. r=yzen
https://hg.mozilla.org/integration/autoland/rev/103dbf465704
Implement move and explore by touch natively. r=geckoview-reviewers,yzen,snorp
https://hg.mozilla.org/integration/autoland/rev/aada27f6ad6e
Implement text navigation natively. r=geckoview-reviewers,Jamie,snorp
https://hg.mozilla.org/integration/autoland/rev/34441585469f
Implement set selection natively. r=geckoview-reviewers,yzen,snorp
https://hg.mozilla.org/integration/autoland/rev/15a754fb192e
Implement clipboard actions natively. r=geckoview-reviewers,yzen,snorp
https://hg.mozilla.org/integration/autoland/rev/7f38c6ddd009
Remove event dispatching to dead code. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/a6b83802832c
Remove AccessFu. r=geckoview-reviewers,yzen,snorp

Comment 21

[Noemi Erli[:noemi_erli]]

Backed out 8 changesets (Bug 1564549) for causing failures in browser_all_files_referenced.js CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=268057346&resultStatus=testfailed%2Cbusted%2Cexception&revision=a6b83802832ce0baaade4f296c406bde187782ee

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268057346&repo=autoland&lineNumber=6433

Backout: https://hg.mozilla.org/integration/autoland/rev/41695a4bc453a658c2977e8bc18b486a4f1963ff

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab7bb18bcca2
Add action forwarding macro. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/83b8e1b49e1e
Introduce native traveral rule. r=yzen
https://hg.mozilla.org/integration/autoland/rev/414ba8c039e6
Implement move and explore by touch natively. r=geckoview-reviewers,yzen,snorp
https://hg.mozilla.org/integration/autoland/rev/9bbf2b19dcfd
Implement text navigation natively. r=geckoview-reviewers,Jamie,snorp
https://hg.mozilla.org/integration/autoland/rev/95544c7598d5
Implement set selection natively. r=geckoview-reviewers,yzen,snorp
https://hg.mozilla.org/integration/autoland/rev/348ec040eaa2
Implement clipboard actions natively. r=geckoview-reviewers,yzen,snorp
https://hg.mozilla.org/integration/autoland/rev/87148740a6c2
Remove event dispatching to dead code. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/5eca1b569290
Remove AccessFu. r=geckoview-reviewers,yzen,snorp

Comment 23

[Eitan Isaacson [:eeejay]]

Needed to conditionally remove AccessFu.properties from shipping on desktop.

Comment 24

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ab7bb18bcca2
https://hg.mozilla.org/mozilla-central/rev/83b8e1b49e1e
https://hg.mozilla.org/mozilla-central/rev/414ba8c039e6
https://hg.mozilla.org/mozilla-central/rev/9bbf2b19dcfd
https://hg.mozilla.org/mozilla-central/rev/95544c7598d5
https://hg.mozilla.org/mozilla-central/rev/348ec040eaa2
https://hg.mozilla.org/mozilla-central/rev/87148740a6c2
https://hg.mozilla.org/mozilla-central/rev/5eca1b569290