1564846 - Geckoview test app generates spurious EGL errors due to GC'd SurfaceTextures

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

Spinoff from https://bugzilla.mozilla.org/show_bug.cgi?id=1516298#c28

The Geckoview test app doesn't hold on to the SurfaceTexture instances it creates, so creating a bunch that are active and then triggering a GC will result in Surfaces that are not backed by anything, and causes random test failures.

:snorp wrote a patch that seems to address it, filing this bug to get that landed.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1564846 - Do better at managing secondary windows in TestRunnerActivity r?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8f19d6b8762
Do better at managing secondary windows in TestRunnerActivity r=kats

Comment 3

[Cosmin Sabou [:CosminS]]

After this bug landed we got a spike in failure rate on tests like css/cssom-view/scroll-behavior-default-css.html | css/cssom-view/scroll-behavior-element.html | css/cssom-view/scroll-behavior-default-css.html
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=android%2Cwpt5&tochange=b8f19d6b876273bc08c8e82bf72282d923a97a7d&fromchange=139206811f54376f9c23c4075ff64183aeb8a44a&selectedJob=255792505

Failure logs: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255792505&repo=autoland&lineNumber=2631
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255794319&repo=autoland&lineNumber=2623

James, please take a look at this. Thank you.

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b8f19d6b8762

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Might be related to what I observed about Surface when investigating an older css-backgrounds wpt intermittent: https://bugzilla.mozilla.org/show_bug.cgi?id=1554777#c12

Comment 6

[Chris Peterson [:cpeterson]]

69=wontfix because James says we don't need to uplift this fix to 69 Beta. We might need to back it out from 70 Nightly for the test issues.

Comment 7

[Cosmin Sabou [:CosminS]]

The patch here was backed out due to high failure rate in bug 1565072. https://hg.mozilla.org/integration/autoland/rev/16da75efcffe8c6cb038fbd4651c30e6dd79e7f5

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/16da75efcffe

Comment 9

[Chris Peterson [:cpeterson]]

I'm editing a bunch of GeckoView bugs. If you'd like to filter all this bugmail, search and destroy emails containing this UUID:

e88a5094-0fc0-4b7c-b7c5-aef00a11dbc9

Comment 10

[Hiroyuki Ikezoe (:hiro)]

:snorp, I am pretty sure your patch fixes bug 1476893. And the failure tests in bug 1565072 have been disabled for a while. I think we can land your patch now.

Here is a try with the patch.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f115dd5878359a8b6f7c1fcdbd25f24e28def0dd

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bdcf118f101
Do better at managing secondary windows in TestRunnerActivity r=kats

Comment 12

[James Willcox (:snorp) ([e-mail]) (he/him)]

lgtm if it works :)

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2bdcf118f101