1565037 - More refactor and cleanup for nsBlockFrame::ComputeFinalBSize()

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, task, P3)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

+++ This bug was initially created as a clone of Bug #1562122 +++

I need to do more refactor until I'm comfortable hacking ComputeFinalBSize() for column-span split.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1565037 Part 1 - Make nsBlockFrame::ComputeFinalBSize() return the final block size. r=dholbert

ComputeFinalBSize() doesn't need to modify the final inline-size, so we
don't need to pass the entire LogicalSize into it.

Also, aReflowInput.AvailableBSize() is used multiple times. Cache it to
shorten some statements.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1565037 Part 2 - Change aStatus to a reference for ComputeFinalBSize(). r=dholbert

We usually use reference to manipulate nsReflowStatus like in Reflow().

The document for aStatus needs edit, and is done in next part.

Depends on D37623

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1565037 Part 3 - Cache our children's reflow status, and use it to guide the morphing into our reflow status. r=dholbert

Because aStatus is also used as an output argument, caching aStatus as
our children's reflow status can and make the logic that morphs aStatus
to our reflow status easier to follow. And this helps the patch I'm
going to add for computing the block-size for column-span split.

Depends on D37624

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1565037 Part 4 - Rename aContentBSize to aBEndEdgeOfChildren. r=dholbert

As described in https://bugzilla.mozilla.org/show_bug.cgi?id=1562122#c5,
this precomputed argument is not content's block-size, but is the
block-end edge of children because aState.mBCoord is initialized as our
border-padding block-start in BlockReflowInput's constructor.

Depends on D37625

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1565037 Part 5 - Rename aBottomEdgeOfChildren to aBEndEdgeOfChildren in methods' declaration. r=dholbert

Their definitions already use aBEndEdgeOfChildren.

Depends on D37626

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/310df636a547
Part 1 - Make nsBlockFrame::ComputeFinalBSize() return the final block size. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/9a3d6bc5a6f9
Part 2 - Change aStatus to a reference for ComputeFinalBSize(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/e72af5bb7aa3
Part 3 - Cache our children's reflow status, and use it to guide the morphing into our reflow status. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/94b17463ded6
Part 4 - Rename aContentBSize to aBEndEdgeOfChildren. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/5fd8ae2c6cde
Part 5 - Rename aBottomEdgeOfChildren to aBEndEdgeOfChildren in methods' declaration. r=dholbert

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/310df636a547
https://hg.mozilla.org/mozilla-central/rev/9a3d6bc5a6f9
https://hg.mozilla.org/mozilla-central/rev/e72af5bb7aa3
https://hg.mozilla.org/mozilla-central/rev/94b17463ded6
https://hg.mozilla.org/mozilla-central/rev/5fd8ae2c6cde