Closed
Bug 1565136
Opened 5 years ago
Closed 5 years ago
Split WipeContainingBlock to save work for those checks requiring no frame construction items
Categories
(Core :: Layout, task, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(1 file)
File this bug per from dbaron's comment in https://phabricator.services.mozilla.com/D36529#1121858.
We currently call WipeContainingBlock after constructing frame construction items, but many of the checks in WipeContainingBlock do not need to inspect these items, e.g. reframing ruby-related frames.
It might worth extracting such logic into another function, and call it before constructing frame construction items to save some work.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/66d48a0fef6b
Move some reframing logic out of WipeContainingBlock to make it done earlier. r=dholbert
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•