Closed Bug 1565159 Opened 5 years ago Closed 5 years ago

Add keyboard access for messages without a CTA link


(Firefox :: Messaging System, enhancement, P1)




Firefox 70
70.4 - Aug 19 - Sep 1
Tracking Status
firefox70 --- fixed


(Reporter: andreio, Assigned: emcminn)



(Keywords: access, Whiteboard: [skyline])


(1 file, 1 obsolete file)

The button is the only element you can focus on, without it you just skip the message when navigating only with the keyboard.

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task

Do we want keyboard focus to go to both the link and the message for those that do have links? Probably not?

Type: task → enhancement
Summary: Messages without a CTA link cannot be accessed by keyboard → Add keyboard access for messages without a CTA link

A quick test shows setting tabindex=0 doesn't seem to work (and curiously the text-link gets tabindex=-1 ? But setting text-link class on the div or whatever makes it tabbable although it also comes with the styling of a text-link. So perhaps alternatively, make the desired tabbable thing a <button> instead of a <div> ?

Keywords: access
Iteration: --- → 70.1 - Jul 8 - 21
Priority: -- → P1
Assignee: nobody → emcminn
Iteration: 70.1 - Jul 8 - 21 → 70.2 - Jul 22 - Aug 4

Making sure this shows up on the Skyline Accessibility radar.

Whiteboard: [skyline]
See Also: → 1569931

Why can't you just use an a with a href attribute, AKA a normal link where a link is due? Because of restrictions with sandboxing? If that's the case, a button is probably the more appropriate element. Or a div with role="link" and tabindex="0" instead of -1. 0 will make it tabable by default. Of course, then you'd need to make sure that Enter opens the link, AKA does the same as OnClick.

Flags: needinfo?(andrei.br92)

We're capturing click events in order to track the events for telemetry. We're then opening the link programmatically.

Flags: needinfo?(andrei.br92)

Hm, then using something similar to what Jamie suggests in bug 1561334 comment #3 might help here, have you investigated that?

Iteration: 70.2 - Jul 22 - Aug 4 → 70.3 - Aug 5 - 18

Replaced the message body div with an unstyled button element, which creates the correct tabbing behavior.

Attachment #9085808 - Attachment is obsolete: true
Iteration: 70.3 - Aug 5 - 18 → 70.4 - Aug 19 - Sep 1
Pushed by
Added keyboard access to WhatsNew panel messages r=k88hudson,andreio
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.