Closed
Bug 1565164
Opened 5 years ago
Closed 4 years ago
Rename "plurals" modules to Lists or equivalent
Categories
(Remote Protocol :: Agent, enhancement, P1)
Remote Protocol
Agent
Tracking
(firefox74 fixed)
RESOLVED
FIXED
Firefox 74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: ochameau, Assigned: ato)
References
Details
(Whiteboard: [puppeteer-beta-mvp])
Attachments
(2 files)
Today we have a few modules/classes which are named in plurals, like Targets and Domains.
They live alongside singular modules/classes, which make it not so obvious to know what we are talking about.
I believe that the code would be easier to understand if we rename them to TargetList and DomainList or equivalent.
|
Assignee | |
Comment 1•5 years ago
|
||
We talked about having domain manifests which explicitly maps a
method to the right object prototype. How does that relate to this?
|
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P3
|
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [puppeteer-beta-reserve]
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
||
Updated•4 years ago
|
Whiteboard: [puppeteer-beta-reserve] → [puppeteer-beta-mvp]
|
||
Updated•4 years ago
|
Attachment #9118510 -
Attachment description: bug 1565164: remote: s/Targets/TargetList/ → bug 1565164: remote: rename Targets TargetList
|
|
||
Updated•4 years ago
|
Attachment #9118511 -
Attachment description: bug 1565164: remote: s/Domains/DomainCache/ → bug 1565164: remote: rename Domains DomainCache
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a059a9ee12d1 remote: rename Targets TargetList r=remote-protocol-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/ded9e8e2beab remote: rename Domains DomainCache r=remote-protocol-reviewers,whimboo
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a059a9ee12d1
https://hg.mozilla.org/mozilla-central/rev/ded9e8e2beab
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in
before you can comment on or make changes to this bug.
Description
•