1565214 - Centralize property restrictions for pseudo-elements, and don't apply it for UA sheets.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Having the flags on each property makes it hard to audit for spec conformance.

Also, making them apply in UA sheets means we have to mark some properties as applying even though they don't, and then we have to remember them in UA sheets.

I was hacking with the placeholder styles for bug 981248, and this patch makes it much nicer / less brittle.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1565214 - Don't apply property restrictions to pseudo-elements in UA stylesheets. r=boris,#style

And remove some of the ::placeholder and ::cue hacks where we need to use
!important to make the property not apply for content but apply on UA sheets.

The comment about the white-space property was wrong, we don't enforce it with
!important in the UA stylesheets for <input> (we do for <textarea> though), so
I've kept the flag since it really applies.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1565214 - Update spec link for font-variation-settings. r=boris,#style

It had got outdated.

Depends on D37717

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1565214 - scroll-margin properties shouldn't apply to first-line / first-letter. r=boris,#style

From https://drafts.csswg.org/css-scroll-snap-1/#placement:

None of the properties in this module apply to the ::first-line and
::first-letter pseudo-elements.

Depends on D37718

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1565214 - Centralize property restrictions. r=boris,#style

The assertion in properties.mako.rs ensures I got this right.

Depends on D37719

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1565214 - Set the property restrictions flags from the centralized list. r=boris,#style

Depends on D37720

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35d45a1cd0b4
Don't apply property restrictions to pseudo-elements in UA stylesheets. r=boris
https://hg.mozilla.org/integration/autoland/rev/0abaee26ddf8
Update spec link for font-variation-settings. r=boris
https://hg.mozilla.org/integration/autoland/rev/a72cf3fdb84b
scroll-margin properties shouldn't apply to first-line / first-letter. r=boris
https://hg.mozilla.org/integration/autoland/rev/9893d5f0a7ba
Centralize property restrictions. r=boris
https://hg.mozilla.org/integration/autoland/rev/29438d93b50a
Set the property restrictions flags from the centralized list. r=boris

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/35d45a1cd0b4
https://hg.mozilla.org/mozilla-central/rev/0abaee26ddf8
https://hg.mozilla.org/mozilla-central/rev/a72cf3fdb84b
https://hg.mozilla.org/mozilla-central/rev/9893d5f0a7ba
https://hg.mozilla.org/mozilla-central/rev/29438d93b50a