1565217 - WebSockets panel should fetch payload only when selected

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is a follow up for bug 1555625

Full WS frame payload is currently fetched when Data column is rendered in the Messages panel. It should happen only if the user actually selects the frame to see the payload in the preview panel.

We should also care about:

• Sorting
• Filtering

Does it work properly if the full payload isn't available?

Honza

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 2

[Hengyeow (:tanhengyeow)]

Attachment: Bug 1565217 - WebSockets panel should fetch payload only when selected. r=nchevobbe,fvsch

Display payload in FrameListColumnData up to 1000 characters

Comment 3

[Hengyeow (:tanhengyeow)]

This is a follow up for bug 1555625

Full WS frame payload is currently fetched when Data column is rendered in the Messages panel. It should happen only if the user actually selects the frame to see the payload in the preview panel.

We should also care about:

• Sorting
• Filtering

Does it work properly if the full payload isn't available?

Honza

In the Phabricator patch attached, the payload would be displayed in the table as it is (cut off at 1000 characters if it is a LongString).

Filtering now does not take into account the full payload (by resolving the async function getLongString). We might need to file a new bug to take care of filtering through all frames' payload taking into account every frame's full payload.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Heng Yeow (:tanhengyeow) from comment #3)

Filtering now does not take into account the full payload (by resolving the async function getLongString). We might need to file a new bug to take care of filtering through all frames' payload taking into account every frame's full payload.

Yes, filing a follow up sounds good to me.

Honza

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1868911b8fbd
WebSockets panel should fetch payload only when selected. r=Honza

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1868911b8fbd