1565226 - Limit the payload rendered in the Preview panel

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

WS frame payload displayed in the Preview panel should be limited the same way as we limit the response body rendered in the Response side panel

This pref is for response body limit
pref("devtools.netmonitor.responseBodyLimit", 1048576);

https://searchfox.org/mozilla-central/rev/f372470e10c8cb0691681603a1d6324dee5b3b8a/devtools/shared/preferences/devtools-shared.js#45

And we need similar for WS frame payload
pref("devtools.netmonitor.messageDataLimit", 1048576);

Honza

Comment 1

[Hengyeow (:tanhengyeow)]

Existing test pages for e.g. http://janodvarko.cz/test/websockets/ https://www.websocket.org/echo.html cut off payload size at around ~200KB and the WS connection is closed once a payload with a larger size is sent.

The pref for network response body limit is set to 1048576 (~1000KB) and we might not observe a payload of this size very often.

After discussing with Harald, we shall set the limit to 100KB first.

Comment 2

[Hengyeow (:tanhengyeow)]

Attachment: Bug 1565226 - Limit the payload rendered in the Preview panel. r=Harald,nchevobbe,fvsch

Limit the payload rendered in the Preview panel to 100 KB

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dbe4c9716a7
Limit the payload rendered in the Preview panel. r=nchevobbe

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7dbe4c9716a7