Closed Bug 1565267 Opened 5 years ago Closed 5 years ago

breach for "dropbox.com" should match login for "www.dropbox.com"

Categories

(Toolkit :: Password Manager, defect, P1)

70 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: groovecoder, Assigned: groovecoder)

References

(Blocks 1 open bug)

Details

(Whiteboard: [skyline])

Attachments

(1 file)

STR:

  1. about:config ; signon.management.page.enabled = true
  2. Have a saved login for https://www.dropbox.com
    1b. (If necessary) edit the "Last modified" date to January 1, 2012 (UNIX timestamp: 1325432128000)
  3. Go to about:logins

Expected results:
The login item for https://www.dropbox.com/ should show a breach indicator

Actual results:
No breach indicator is shown

:MattN and I previously decided on "strict subdomain matching when there is a subdomain in the breach.Domain", but I accidentally implemented strict subdomain matching for both the breach.Domain and the login.host.

Need to update to only match subdomains when there's a subdomain in breach.Domain.

Assignee: nobody → lcrouch
Priority: -- → P1
Blocks: 1565326
No longer blocks: 1559365

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Type: defect → enhancement
Whiteboard: [skyline]
Type: enhancement → defect
Attachment #9077482 - Attachment description: Bug 1565267: match base domains of logins and breaches r=MattN → Bug 1565267: match root domains of logins and breaches r?MattN
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/c86bb4e43fcb
match root domains of logins and breaches r=MattN
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: