1565267 - breach for "dropbox.com" should match login for "www.dropbox.com"

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Luke Crouch [:groovecoder]]

STR:

0. about:config ; signon.management.page.enabled = true
1. Have a saved login for https://www.dropbox.com
   1b. (If necessary) edit the "Last modified" date to January 1, 2012 (UNIX timestamp: 1325432128000)
2. Go to about:logins

Expected results:
The login item for https://www.dropbox.com/ should show a breach indicator

Actual results:
No breach indicator is shown

:MattN and I previously decided on "strict subdomain matching when there is a subdomain in the breach.Domain", but I accidentally implemented strict subdomain matching for both the breach.Domain and the login.host.

Need to update to only match subdomains when there's a subdomain in breach.Domain.

Comment 1

[Luke Crouch [:groovecoder]]

Attachment: Bug 1565267: match root domains of logins and breaches r?MattN

Comment 2

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c86bb4e43fcb
match root domains of logins and breaches r=MattN

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c86bb4e43fcb