nsPageSequenceFrame.h includes itself
Categories
(Core :: Printing: Setup, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: calixte, Assigned: calixte)
References
Details
Attachments
(1 file)
For reference:
https://searchfox.org/mozilla-central/source/layout/generic/nsPageSequenceFrame.h#10
I didn't find any other file with this name so it's likely a self inclusion.
|
||
Comment 1•5 years ago
|
||
Good catch! This was a minor mistake in bug 1557104.
Specifically here:
https://hg.mozilla.org/mozilla-central/rev/301eb76934ab#l14.1
(We previously had nsSimplePageSequenceFrame.h which included nsIPageSequenceFrame.h, but we merged those into a single header in bug 1557104. As part of that, we updated nsIPageSequenceFrame.h #includes to point at nsPageSequenceFrame.h instead, including the one within nsSimplePageSequenceFrame.h itself (which was simultaneously becoming nsPageSequenceFrame.h)
We can just remove this #include line. It's harmless & useless in its current state. calixte, were you planning on doing that? If not, I'm happy to do so.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
nsPageSequenceFrame.h includes itself.
Pushed by cdenizet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f6a326c94c53 Remove self inclusion from nsPageSequenceFrame.h r=dholbert
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•