Closed
Bug 1565312
Opened 6 years ago
Closed 6 years ago
Circular inclusion between Shutdown.h and Database.h
Categories
(Toolkit :: Places, task, P3)
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: calixte, Assigned: calixte)
Details
Attachments
(1 file)
For reference:
https://searchfox.org/mozilla-central/source/toolkit/components/places/Shutdown.h#9
https://searchfox.org/mozilla-central/source/toolkit/components/places/Database.h#17
The inclusion of Database.h in Shutdown.h seems to be useless.
|
||
Comment 1•6 years ago
|
||
there is a foward declaration of class Database, so yes, likely the Database.h include can be removed.
Priority: -- → P3
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → cdenizet
|
|
Assignee | |
Comment 2•6 years ago
|
||
The inclusion of Database.h is useless (there's a fwd declaration of Database) and leads to a circular inclusion.
Pushed by cdenizet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd7ecdadf149
Remove useless include of Database.h in Shutdown.h r=mak
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•