Closed Bug 1565407 Opened 4 years ago Closed 4 years ago

Make available and enable password generation on desktop

Categories

(Toolkit :: Password Manager, enhancement, P1)

Product:
Toolkit
Component:
Password Manager
Platform:
Desktop
All
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
relnote-firefox --- 70+
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 + fixed

People

(Reporter: MattN, Assigned: ntim)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, Whiteboard: [passwords:generation] [skyline])

Attachments

(1 file)

Bug 1565407 - Enable password generation and make it available by default.
47 bytes, text/x-phabricator-request
Details | Review

Flip the two prefs to true:

  • signon.generation.available controls whether the feature is available for users (e.g. if the about:preferences UI should show).
  • signon.generation.enabled is the user pref to enable/disable the feature from about:preferences.

Release Note Request (optional, but appreciated)
[Why is this notable]: New feature
[Affects Firefox for Android]: No
[Suggested wording]: Firefox can now suggest securely generated passwords from the context menu and autocomplete (on supported sites)
[Links (documentation, blog post, etc)]: https://wiki.mozilla.org/Toolkit:Password_Manager/Password_Generation#Firefox_70_.28Desktop_only.29

  • autocomplete support is limited to sites using autocomplete=new-password
relnote-firefox: --- → ?
Keywords: dev-doc-needed

The prefs should be set in firefox.js, not all.js, so it's not enabled on Android: https://searchfox.org/mozilla-central/rev/15be167a5b436b57fef944b84eef061d24c1af8c/browser/app/profile/firefox.js#1737-1748

Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/842d2fac0842
Enable password generation and make it available by default. r=MattN

https://hg.mozilla.org/mozilla-central/rev/842d2fac0842

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox70: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

This was added last week to Nightly release notes

As an FYI, the dev-doc-needed password is only to do with MDN documentation; we don't have anything to do with updating WikiMo. And I'm not sure who does do that ;-)

Flags: needinfo?(MattN+bmo)
Keywords: dev-doc-needed

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #9)

As an FYI, the dev-doc-needed password is only to do with MDN documentation; we don't have anything to do with updating WikiMo. And I'm not sure who does do that ;-)

Right, I wasn't wanting anything documented on the wiki, I provided a link to the feature documentation.

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

  • autocomplete support is limited to sites using autocomplete=new-password

This is what I thought could be documented on MDN.

Flags: needinfo?(MattN+bmo)
Keywords: dev-doc-needed

Right, I wasn't wanting anything documented on the wiki, I provided a link to the feature documentation.

Gah, sorry for the misunderstanding; Friday tiredness! I'll get this put into our next sprint.

This bug does not appear to affect browser-compat data, since the new-password value was supported since 67.

Keywords: dev-doc-needed → dev-doc-complete
Depends on: 1589795
You need to log in before you can comment on or make changes to this bug.