Closed
Bug 1565410
Opened 7 years ago
Closed 7 years ago
[api] Don't expose BundleEventListener
Categories
(GeckoView :: General, defect, P3)
Tracking
(firefox69 wontfix, firefox70 fixed)
RESOLVED
FIXED
mozilla70
People
(Reporter: agi, Assigned: agi)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 external file)
Bug 1539144 added WebExtensionController which implements BundleEventListener. Since BundleEventListener is a private class we should not expose it in the API.
This should have been caught by apilint but wasn't, bug for this is at https://github.com/mozilla-mobile/gradle-apilint/issues/62 (fixed in 0.2.2)
| Assignee | ||
Updated•7 years ago
|
Assignee: nobody → agi
| Assignee | ||
Comment 1•7 years ago
|
||
This also updates apilint to 0.2.2 to ensure that future instances of this
problem will be caught automatically.
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d35d90d0322b
Don't expose BundleEventListener in the API. r=esawin
Comment 3•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Comment 4•7 years ago
|
||
This bug was backed out due to conflicts while backing out bug 1557096.
Backout link: https://hg.mozilla.org/mozilla-central/rev/0fb761cd8fa448eb511e8b2520ede5a3230853ed
Status: RESOLVED → REOPENED
status-firefox70:
fixed → ---
Flags: needinfo?(agi)
Resolution: FIXED → ---
Target Milestone: mozilla70 → ---
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2180268af1d
Don't expose BundleEventListener in the API. r=esawin
| Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(agi)
Comment 6•7 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Comment 7•7 years ago
|
||
69=wontfix because we don't need to uplift this API fix to GV 69 Beta.
status-firefox69:
--- → wontfix
Updated•4 years ago
|
Has Regression Range: --- → yes
Updated•4 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•