1565418 - latest firefox build version 68 upgrade broke my company's menu

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Anthony Tsao]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134

Actual results:

latest version https://www.ssfautoparts.com
the menu tab does not work anymore. Still works on older version 66

Non of our client can use latest firefox to do business on our website.

Expected results:

The menu click should load different ajax content.

Comment 1

[Anthony Tsao]

Just to be specific not all menu are broken. Certain menu item if you compare it with Chrome. Click on Expertise on the top menu tab and then click on either Car Lines and SSF Technical does not work. But other menu tab still functional.

Comment 2

[Tooru Fujisawa [:arai]]

(edited, to add URL)

https://www.ssfautoparts.com/assets/scripts/public-02122018.min.js

function LoadThisPage(objID, Page, root, loginContent, thisMenu, shopMenu, shopMenuTab, menuDisp) {
...
    if (window.ActiveXObject) {
...
    } else if (window.XMLHttpRequest) {
...
        if (is_chrome_safari || isNewIERV) {
            var xhReq = new XMLHttpRequest();
            xhReq.open("GET", url, false);
            xhReq.send(null);
            var PageContent = xhReq.responseXML.getElementsByTagName("PageContent");
            if (PageContent != null || PageContent[0].firstChild.data != 'Not Valid') {
                PageContent = PageContent[0].firstChild.data;
                //document.getElementById(objID).innerHTML = '<div>Loading Page...</div>';
                resetScroll();
                setTimeout(function () {
                    document.getElementById(objID).innerHTML = PageContent;
                    if (canGetCookie) {
                        getCookie(root + 'getCookie.aspx');
                    }
                }, 0);
            }
        } else {
            oLoadedXML = document.implementation.createDocument("", "", null);
            oLoadedXML.async = false;
            var loaded = oLoadedXML.load(url);

This code uses XMLDocument.prototype.load [1] that is non-standard and removed recently [2]

then, if I modify if (is_chrome_safari || isNewIERV) { line above to just if (true) {, it seems to work.

[1] https://developer.mozilla.org/en-US/docs/Web/API/XMLDocument/load
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=332175

Comment 3

[Boris Zbarsky [:bzbarsky]]

Anthony, thank you for the bug report.

Is it possible for your company's site to fix its sniffing to not run different code in Firefox from all other browsers? That should fix the problem...

Comment 4

[Anthony Tsao]

Yes we can try that. We update again shortly.

Comment 5

[Anthony Tsao]

o.k. Thanks we made some changes based on your suggestion not to do the outdated xml load appears to be working now.