1565502 - moz-phab hanging/spinning while performing long running actions

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Ruchika Gosain]

Attachment: Screenshot 2019-07-12 at 2.33.23 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

After changing directory to <mozilla-central>, I ran the following command to submit my patch:
/Users/ruchikagosain/Desktop/review/moz-phab submit

Actual results:

The terminal hung and it shows "looking for commits" for as long as terminal runs.
At last, I had to kill the process.
Even after <self-update> command, the above process repeated.

Expected results:

The patch should have been submitted for review via moz-phab.

Comment 1

[:glob ✱]

Please re-run using the following command and attach the output:

DEBUG=1 /Users/ruchikagosain/Desktop/review/moz-phab submit

As this will generate a lot of output copy and pasting the text into an attachment would be better/easier than attaching a screenshot.

Comment 2

[:glob ✱]

we've had a few more reports of this spinning, including zalun hitting this in his dev environment.

appears to be related to the progress spinner.

Comment 3

[Piotr Zalewa [:zalun]]

@njn Do you remember the message the spinner displayed when stuck?

Comment 4

[Nicholas Nethercote [inactive]]

The last line of the terminal output said Updating D39133.. with the text spinner at the end of the line.

Comment 5

[Piotr Zalewa [:zalun]]

Thanks, so it's really random - I've asked as in my local environment it was constantly hanging on one command, but it was just a coincident.
I'm removing the spinner for now.

Comment 6

[Piotr Zalewa [:zalun]]

Attachment: Bug 1565502 - Temporarily switching off the spinner

Comment 7

[Karl Tomlinson (:karlt)]

Got at far as "Submitting 1 commit for review:\n Loading commits /" and spinning.
Not using much cpu. No network connections.
^C doesn't interrupt. ^\ does.

Comment 8

[Piotr Zalewa [:zalun]]

I've created a release without the spinner. Please report if this would happen again.
I'll continue to work on fixing it properly.

Comment 10

[Piotr Zalewa [:zalun]]

I've switched it to check if the problem solved itself after the move to Python3.
I've run it a few hundred times in the suite environment. No hangs (I remember it was hanging about 1-3% of the time)
Do you think we can just switch it on?

Comment 11

[Piotr Zalewa [:zalun]]

Attachment: Bug 1565502 - Bring back the Spinner. r=glob,zeid