156568 - data dir is not correctly created

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Bradley Baetz (:bbaetz)]

checksetup.pl has an |unless (-d 'data')| block.

However, this comes after the include of globals.pl, and globals.pl creates a
new template object, which creates 'data' and 'data/template' for us, becuase of
the COMPILE_DIR.

We need to move just that block to above the |require|, to ensure that the other
files are created.

To be honest, I don't know if thats needed - I suspect the code deals with those
files not existing w/o problems.

Comment 1

[Bradley Baetz (:bbaetz)]

-> 2.16

Comment 2

[Bradley Baetz (:bbaetz)]

Attachment: v1

This is actually simpler - just change the initial check to see if data/nomail
exists, also.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 90705 [details] [diff] [review]
v1

>Index: checksetup.pl
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v
>retrieving revision 1.160
>diff -u -r1.160 checksetup.pl
>--- checksetup.pl	9 Jul 2002 23:40:31 -0000	1.160
>+++ checksetup.pl	10 Jul 2002 00:16:02 -0000
>@@ -637,7 +637,12 @@
> # Create initial --DATA-- directory and make the initial empty files there:
> #
> 
>-unless (-d 'data') {
>+# The |require "globals.pl"| above ends up creating a template object.with

Nit: object.with -> object with

2xr=myk

Comment 4

[Bradley Baetz (:bbaetz)]

Checked in, trunk + branch