Closed Bug 156568 Opened 21 years ago Closed 21 years ago

data dir is not correctly created

Categories

(Bugzilla :: Installation & Upgrading, defect)

x86
Linux
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: bbaetz, Assigned: bbaetz)

Details

(Keywords: regression)

Attachments

(1 file)

checksetup.pl has an |unless (-d 'data')| block.

However, this comes after the include of globals.pl, and globals.pl creates a
new template object, which creates 'data' and 'data/template' for us, becuase of
the COMPILE_DIR.

We need to move just that block to above the |require|, to ensure that the other
files are created.

To be honest, I don't know if thats needed - I suspect the code deals with those
files not existing w/o problems.
-> 2.16
Severity: normal → minor
Keywords: regression
Target Milestone: --- → Bugzilla 2.16
Attached patch v1Splinter Review
This is actually simpler - just change the initial check to see if data/nomail
exists, also.
Comment on attachment 90705 [details] [diff] [review]
v1

>Index: checksetup.pl
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v
>retrieving revision 1.160
>diff -u -r1.160 checksetup.pl
>--- checksetup.pl	9 Jul 2002 23:40:31 -0000	1.160
>+++ checksetup.pl	10 Jul 2002 00:16:02 -0000
>@@ -637,7 +637,12 @@
> # Create initial --DATA-- directory and make the initial empty files there:
> #
> 
>-unless (-d 'data') {
>+# The |require "globals.pl"| above ends up creating a template object.with

Nit: object.with -> object with

2xr=myk
Attachment #90705 - Flags: review+
Checked in, trunk + branch
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.