Closed
Bug 1565715
Opened 5 years ago
Closed 5 years ago
The Preview highlight should only highlight a single token
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: jlast, Assigned: janelledement)
References
(Blocks 2 open bugs)
Details
(Keywords: good-first-bug)
Attachments
(2 files, 1 obsolete file)
Screen Shot 2019-07-08 at 3.59.15 PM.png
It looks like it is possible to trick the preview highlighter into highlighting several tokens if there are multiple properties like object.data.value ...
|
Reporter | |
Comment 1•5 years ago
|
||
|
|
Reporter | |
Updated•5 years ago
|
Keywords: good-first-bug
|
||
Updated•5 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 2•5 years ago
|
||
Fixes yellow highlight being added to multiple parent properties like `object.data.value'.
|
|
Assignee | |
Comment 3•5 years ago
|
||
By tweaking the while loop in addHighlightToTargetSiblings, the preview highlight will not continue beyond a non-text node. (Example in the case of a semi colon or a period.
|
||
Updated•5 years ago
|
Attachment #9089549 -
Attachment description: Original solution: Stop preview highlight at non-element nodes. → Bug 1565715 - Stop preview highlight at non-element nodes. r=jlast
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7541967adbed
Stop preview highlight at non-element nodes.
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
|
||
Updated•5 years ago
|
Assignee: nobody → janelledement
|
|
||
Updated•5 years ago
|
Attachment #9079853 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•