Closed Bug 1565718 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17383 - Make ChannelMerger active processing test less flaky

Categories

(Core :: Web Audio, task, P4)

Product:
Core
Component:
Web Audio
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17383 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17383
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Make ChannelMerger active processing test less flaky

Replace the offline audio context with a realtime context and an AudioWorklet.
Previously, when the source stopped, the channel count change would sometimes
get delayed until rendering is done, which is too late for the test. I believe
this is because the main thread was previously too busy to process the messages
to disable outputs and change the channel count.

Using a realtime context makes the main thread less busy because the messages
aren't posted as fast as possible, allowing time for them to be handled. I think
this is still flaky, but much less so than before.

Bug: 974258
Test: the-channelmergernode-interface/active-processing.https.html
Change-Id: Id584ebfa5f54ad6870819f5242aafed5f4fc80d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663186
Reviewed-by: Hongchan Choi \<hongchan@chromium.org>
Commit-Queue: Raymond Toy \<rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677078}

Component: web-platform-tests → Web Audio
Product: Testing → Core
Type: -- → task
Ran 1 tests and 5 subtests PASS : 5 ERROR : 1
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/b9d06183724a [wpt PR 17383] - Make ChannelMerger active processing test less flaky, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b9d06183724a

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.