Closed Bug 1565785 Opened 3 years ago Closed 3 years ago

Skip WR rendering until window becomes ready to draw on Wayland

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

On wayland, we could not render with WR until window becomes ready. And WR rendering without EGLSurface caused a problem of Bug 1553887. It is necessary to skip WR rendering until window becomes ready to draw.

Assignee: nobody → sotaro.ikeda.g
Type: task → enhancement
Blocks: wayland, wr-linux
Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1f8f86bbda8
Skip WR rendering until window becomes ready to draw on Wayland r=nical

Backed out changeset b1f8f86bbda8 (Bug 1565785) for causing bustages in nsWindow.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/65d50c140899afc06caf11d53665d268326a5f16

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=b1f8f86bbda881ec9bc3293f07b8570590f7ed06&selectedJob=256648024

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=256648024&repo=autoland&lineNumber=24730
[task 2019-07-16T00:07:20.485Z] 00:07:20 INFO - In file included from /builds/worker/workspace/build/src/widget/gtk/GtkCompositorWidget.cpp:12:0,
[task 2019-07-16T00:07:20.485Z] 00:07:20 INFO - from /builds/worker/workspace/build/src/obj-firefox/widget/gtk/Unified_cpp_widget_gtk0.cpp:20:
[task 2019-07-16T00:07:20.485Z] 00:07:20 INFO - /builds/worker/workspace/build/src/widget/gtk/nsWindow.h: In member function 'virtual bool nsWindow::CompositorInitiallyPaused()':
[task 2019-07-16T00:07:20.485Z] 00:07:20 ERROR - /builds/worker/workspace/build/src/widget/gtk/nsWindow.h:413:12: error: 'mNeedsUpdatingEGLSurface' was not declared in this scope
[task 2019-07-16T00:07:20.485Z] 00:07:20 INFO - return mNeedsUpdatingEGLSurface;
[task 2019-07-16T00:07:20.486Z] 00:07:20 INFO - ^~~~~~~~~~~~~~~~~~~~~~~~
[task 2019-07-16T00:07:20.486Z] 00:07:20 INFO - /builds/worker/workspace/build/src/config/rules.mk:801: recipe for target 'Unified_cpp_widget_gtk0.o' failed
[task 2019-07-16T00:07:20.486Z] 00:07:20 ERROR - make[4]: *** [Unified_cpp_widget_gtk0.o] Error 1
[task 2019-07-16T00:07:20.486Z] 00:07:20 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/widget/gtk'
[task 2019-07-16T00:07:20.486Z] 00:07:20 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2019-07-16T00:07:20.486Z] 00:07:20 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/editor/libeditor'
[task 2019-07-16T00:07:20.486Z] 00:07:20 INFO - editor/libeditor/Unified_cpp_editor_libeditor2.o

Flags: needinfo?(sotaro.ikeda.g)

mNeedsUpdatingEGLSurface is defined when MOZ_WAYLAND is defined. It needs to handle it.

Flags: needinfo?(sotaro.ikeda.g)
Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/840b6bd9e818
Skip WR rendering until window becomes ready to draw on Wayland r=nical
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Depends on: 1566468
Blocks: 1565583
Blocks: 1553887
Regressions: 1568748
Regressions: 1588987
You need to log in before you can comment on or make changes to this bug.