1565991 - Calling createPattern with `new Image()` must return null

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

document.createElement("canvas").getContext("2d").createPattern(new Image(), "no-repeat")

Currently the code throws instead of returning null.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Relevant spec: https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-createpattern

It seems new Image() is immediately considered as broken 🤔

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

nsImageLoadingContent initially sets mBroken as true but the spec says the initial state should be unavailable.

Comment 3

[Kris Taeleman (:ktaeleman)]

Attachment: Bug 1565991 - Make createpattern return null instead of throw.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f69e1e9da360
Ensure calling createPattern with `new Image()` returns null. r=jrmuizel

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18697 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out changeset f69e1e9da360 (Bug 1565991) for failing in test_createPattern_broken.html

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=f69e1e9da360ddb82c69ae7328710ab9dd339c96&searchStr=linux%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Ctest-linux64-qr%2Fdebug-mochitest-e10s-3%2Cm%283%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263711762&repo=autoland&lineNumber=5871
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263711537&repo=autoland&lineNumber=11248

Backout: https://hg.mozilla.org/integration/autoland/rev/812f0c821d05280423ec5ceef539f89d2ccac912

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c1a726f2190
Make createpattern return null instead of throw. r=jrmuizel

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1565991. Mark some additional tests as passing.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5abd597f5d2d
Mark some additional tests as passing. a=wpt-fix

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84e78280c066
Update expectation for 2d.pattern.image.incomplete.emptysrc.html a=wpt-fix

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2c1a726f2190
https://hg.mozilla.org/mozilla-central/rev/5abd597f5d2d
https://hg.mozilla.org/mozilla-central/rev/84e78280c066

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot