1565997 - CanvasPattern.setTransform does not support DOMMatrix

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

// Assuming `$0` refers to a valid HTMLImageElement
document.createElement("canvas").getContext("2d").createPattern($0, "no-repeat").setTransform(new DOMMatrix());

Currently this code throws: TypeError: Argument 1 of CanvasPattern.setTransform does not implement interface SVGMatrix.

Relevant spec: https://html.spec.whatwg.org/multipage/canvas.html#2dcontext:dom-canvaspattern-settransform

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Do other browsers support it?

Comment 2

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

Chrome supports it. Example: https://codepen.io/SaschaNaz/pen/zVgjrM

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Does WebKit/Safari?

Comment 4

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

Confirmed that it also works on WK, tested on epiphany-browser.

Comment 5

[Robert Longson [:longsonr]]

Attachment: Bug 1565997 - CanvasPattern.setTransform should take a DOMMatrix2DInit

Comment 6

[Robert Longson [:longsonr]]

I'm stuck trying to create the new tests

./build.sh

Traceback (most recent call last):
File "gentest.py", line 1, in <module>
from gentestutils import genTestUtils
File "/moz2/mozilla-central/testing/web-platform/tests/html/canvas/tools/gentestutils.py", line 47, in <module>
import cairocffi as cairo
File "/moz2/mozilla-central/testing/web-platform/tests/html/canvas/tools/.virtualenv/lib/python2.7/site-packages/cairocffi/init.py", line 41, in <module>
cairo = dlopen(ffi, 'cairo', 'cairo-2', 'cairo-gobject-2')
File "/moz2/mozilla-central/testing/web-platform/tests/html/canvas/tools/.virtualenv/lib/python2.7/site-packages/cairocffi/init.py", line 38, in dlopen
raise OSError("dlopen() failed to load a library: %s" % ' / '.join(names))
OSError: dlopen() failed to load a library: cairo / cairo-2 / cairo-gobject-2

Comment 7

[Lee Salzman [:lsalzman]]

I am not really familiar with the WPT test setup as I've not messed with it much at all. Probably better to ping someone more familiar with the WPT tooling. Emilio, ideas about who might have suitable knowledge to help here?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

James, Sam, is any of you familiar with the build setup for the canvas tests?

Though off-hand it seems you may need cairo installed or something on your machine.

Comment 9

[Robert Longson [:longsonr]]

Fixed things via

brew install cairo

Thank you.

Comment 10

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=290c2590231bbde5962bdda4bff9f505a0377d3b&selectedTaskRun=CMBITO7ETIqc0Dl8NwL3xw.0

Comment 11

[Robert Longson [:longsonr]]

Did you want to review this or are you happy with emilio's review alone?

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a67e6a4d23d
CanvasPattern.setTransform should take a DOMMatrix2DInit r=emilio,lsalzman

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24330 for changes under testing/web-platform/tests

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3a67e6a4d23d

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 17

[Chris Mills [:cmills]]

I've finished the documentation for this; see https://github.com/mdn/sprints/issues/3424#issuecomment-652956306 for full details.