Closed
Bug 1566002
Opened 5 years ago
Closed 5 years ago
Remove unnecessary key values and replace componentWillReceiveProps
Categories
(DevTools :: Netmonitor, task, P2)
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: tanhengyeow, Assigned: tanhengyeow)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Bug 1566002 - Remove unnecessary key values and replace componentWillReceiveProps. r=nchevobbe,fvsch
47 bytes,
text/x-phabricator-request
|
Details | Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36
Expected results:
- Remove unnecessary key values in new components related to WS monitor.
Keys are only needed in the parent component where Array.map
is done. Some components for e.g. FrameListColumnData
do not need key values.
- Replace
componentWillReceiveProps
.
componentWillReceiveProps
(aliased to UNSAFE_componentWillReceiveProps) is getting deprecated in React and likely to be removed in a next major version. We should consider replacing it with componentDidUpdate
instead.
Assignee | ||
Updated•5 years ago
|
Blocks: network-websocket-inspector
Type: defect → task
Comment 1•5 years ago
|
||
Thanks for the report!
Honza
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Updated•5 years ago
|
Blocks: network-websocket-inspector-m1
Updated•5 years ago
|
Priority: P3 → P2
Assignee | ||
Comment 2•5 years ago
|
||
Remove unnecessary key values, replace componentWillReceiveProps, did some cleanup
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5be4c15a9e0d
Remove unnecessary key values and replace componentWillReceiveProps. r=nchevobbe
Updated•5 years ago
|
Assignee: nobody → E0032242
Status: NEW → ASSIGNED
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•