1566002 - Remove unnecessary key values and replace componentWillReceiveProps

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P2)

Description

[Hengyeow (:tanhengyeow)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Expected results:

1. Remove unnecessary key values in new components related to WS monitor.

Keys are only needed in the parent component where Array.map is done. Some components for e.g. FrameListColumnData do not need key values.

2. Replace componentWillReceiveProps.

componentWillReceiveProps (aliased to UNSAFE_componentWillReceiveProps) is getting deprecated in React and likely to be removed in a next major version. We should consider replacing it with componentDidUpdate instead.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!
Honza

Comment 2

[Hengyeow (:tanhengyeow)]

Attachment: Bug 1566002 - Remove unnecessary key values and replace componentWillReceiveProps. r=nchevobbe,fvsch

Remove unnecessary key values, replace componentWillReceiveProps, did some cleanup

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5be4c15a9e0d
Remove unnecessary key values and replace componentWillReceiveProps. r=nchevobbe

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5be4c15a9e0d