Closed Bug 1566019 Opened 4 months ago Closed 4 months ago

Sorting by the URL column causes the Network panel to go blank.


(DevTools :: Netmonitor, defect, P1)



(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox68 unaffected, firefox69 fixed, firefox70 fixed)

Firefox 70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- fixed
firefox70 --- fixed


(Reporter: Honza, Assigned: Honza)




(Keywords: regression)


(1 file, 1 obsolete file)

This is a follow up for bug 1341155

See this comment


  1. Open the Network panel
  2. Right click the columns header and make the URL column visible by default
  3. Click on URL column header -> The entire panel goes blank.

There is an exception in the Browser console

TypeError: sorter is not a function - selectors/requests.js:36:10


Priority: -- → P1
Attached patch Missing sorter added (obsolete) — Splinter Review

Some analysis done, missing sorter added
This should also have a test to avoid regressions in the future.

We already have the following test:

and it should be extended to cover also the URL column.


Assignee: nobody → odvarko
Assignee: odvarko → nobody

Nicolas, could you please take a look at this?
We should fix ASAP and uplift to 69

Flags: needinfo?(nchevobbe)

I reproduced the exception with STR from Comment 1.
Then I applied the patch and everything was fine.
I enabled all the columns and sorted by each of them a few time, and everything looks good.

Flags: needinfo?(nchevobbe)
Pushed by
Fix URL column sorting + test r=nchevobbe
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Attachment #9078115 - Attachment is obsolete: true

Comment on attachment 9078123 [details]
Fix URL column sorting + test

Beta/Release Uplift Approval Request

  • User impact if declined: When sorting data in the Network panel (Developer Toolbox) the panel goes blank (breaks)
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Only affects developers (not regular Firefox users) + relatively small patch.
  • String changes made/needed:
Attachment #9078123 - Flags: approval-mozilla-beta?

Comment on attachment 9078123 [details]
Fix URL column sorting + test

Fixes a devtools regression in 69 and includes a regression test. Approved for 69.0b6.

Attachment #9078123 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.