1566019 - Sorting by the URL column causes the Network panel to go blank.

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is a follow up for bug 1341155

See this comment
https://bugzilla.mozilla.org/show_bug.cgi?id=1341155#c21
Honza

STR:

1. Open the Network panel
2. Right click the columns header and make the URL column visible by default
3. Click on URL column header -> The entire panel goes blank.

There is an exception in the Browser console

TypeError: sorter is not a function - selectors/requests.js:36:10

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Missing sorter added

Some analysis done, missing sorter added
This should also have a test to avoid regressions in the future.

We already have the following test:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/test/browser_net_sort-02.js

and it should be extended to cover also the URL column.

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Nicolas, could you please take a look at this?
We should fix ASAP and uplift to 69
Honza

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

I reproduced the exception with STR from Comment 1.
Then I applied the patch and everything was fine.
I enabled all the columns and sorted by each of them a few time, and everything looks good.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Fix URL column sorting + test

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5cfe00d469cfa25d7c1b2e91f3d6656b7a0a594

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ff00ec7687f
Fix URL column sorting + test r=nchevobbe

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4ff00ec7687f

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 9078123 [details]
Fix URL column sorting + test

Beta/Release Uplift Approval Request

• User impact if declined: When sorting data in the Network panel (Developer Toolbox) the panel goes blank (breaks)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects developers (not regular Firefox users) + relatively small patch.
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078123 [details]
Fix URL column sorting + test

Fixes a devtools regression in 69 and includes a regression test. Approved for 69.0b6.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/06a0ccc9f374