CacheIR op guardIndexGreaterThanDenseCapacity is dead code
Categories
(Core :: JavaScript Engine: JIT, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: mgaudet, Assigned: tuan.mate, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=c++])
Attachments
(2 files)
Right now the CacheIR op guardIndexGreaterThanDenseCapacity
is dead code
(noticed this via the CodeCov report)
Probably can be deleted, but ni?djvj to verify -- if so, will mark as good-first-bug.
Comment 1•6 years ago
|
||
Or add a test case.
Reporter | ||
Comment 2•6 years ago
|
||
There's nothing that can actually generate the op; not sure of the history behind why the consumer was lost.
Comment 3•6 years ago
|
||
Ah, I think we ended up changing this around and orphaning it when we landed the IC changes to sparse array updates. I didn't want to remove it right then because it's a valid semantic check that might be useful later.
I'm not hard and fast on some decision here. If you think it should be ripped out, I'll oblige with an r+.
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Comment 4•6 years ago
|
||
Hello, I would like to work on this bug. Could you please guide me to the part of the code related to the bug and please explain what exactly is to be done.
Reporter | ||
Comment 6•6 years ago
|
||
I won't assign the bug: However, if you use https://searchfox.org/ you can find the relevant code, delete it and produce a patch.
See the walkthrough here for guidance.
Comment 7•6 years ago
|
||
Updated•6 years ago
|
Reporter | ||
Updated•5 years ago
|
Comment 8•5 years ago
|
||
Is the bug still open. I would like to work on this with some mentoring.
Reporter | ||
Comment 9•5 years ago
|
||
Hi Kiran,
You can definitely jump on this bug. I'll post my "New Contributors" template below to give you some pointers and set some expectations!
Prerequisites
Before getting started, you'll want to
- You Have a checkout of the Firefox source code
- Make sure you can build SpiderMonkey
- Understand the basics of using Mercurial
- Understand how to submit a patch
- Read this walkthrough about how development works in Firefox
Success Criteria
- The op guardIndexGreaterThanDenseCapacity and it's emitter have been removed
- After this removal, the engine compiles, and passes the tests (run
../jit-test/jit_test.py ./dist/bin/js
from your build directory)
Questions
If you have questions, feel free to visit us on in the Spidermonkey room on Matrix, or post questions here.
Comment 10•5 years ago
|
||
Hey
Is this bug still open?
Assignee | ||
Comment 11•5 years ago
|
||
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
bugherder |
Description
•