Closed Bug 1566116 Opened 6 years ago Closed 5 years ago

CacheIR op guardIndexGreaterThanDenseCapacity is dead code

Categories

(Core :: JavaScript Engine: JIT, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: mgaudet, Assigned: tuan.mate, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++])

Attachments

(2 files)

Right now the CacheIR op guardIndexGreaterThanDenseCapacity is dead code

(noticed this via the CodeCov report)

Probably can be deleted, but ni?djvj to verify -- if so, will mark as good-first-bug.

Flags: needinfo?(kvijayan)

Or add a test case.

There's nothing that can actually generate the op; not sure of the history behind why the consumer was lost.

Ah, I think we ended up changing this around and orphaning it when we landed the IC changes to sparse array updates. I didn't want to remove it right then because it's a valid semantic check that might be useful later.

I'm not hard and fast on some decision here. If you think it should be ripped out, I'll oblige with an r+.

Flags: needinfo?(kvijayan)
Priority: -- → P3
Mentor: mgaudet
Keywords: good-first-bug
Whiteboard: [lang=c++]

Hello, I would like to work on this bug. Could you please guide me to the part of the code related to the bug and please explain what exactly is to be done.

Is this bug still available ? I would like to work on this

I won't assign the bug: However, if you use https://searchfox.org/ you can find the relevant code, delete it and produce a patch.

See the walkthrough here for guidance.

Assignee: nobody → shrey2809
Status: NEW → ASSIGNED
Assignee: shrey2809 → nobody
Status: ASSIGNED → NEW

Is the bug still open. I would like to work on this with some mentoring.

Flags: needinfo?(mgaudet)

Hi Kiran,

You can definitely jump on this bug. I'll post my "New Contributors" template below to give you some pointers and set some expectations!

Prerequisites

Before getting started, you'll want to

Success Criteria

  • The op guardIndexGreaterThanDenseCapacity and it's emitter have been removed
  • After this removal, the engine compiles, and passes the tests (run ../jit-test/jit_test.py ./dist/bin/js from your build directory)

Questions

If you have questions, feel free to visit us on in the Spidermonkey room on Matrix, or post questions here.

Flags: needinfo?(mgaudet)

Hey
Is this bug still open?

Assignee: nobody → tuan.mate
Status: NEW → ASSIGNED
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77eab1e3c3ae Remove CacheIR op guardIndexGreaterThanDenseCapacity and it's emitter. r=jandem
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: