Closed Bug 1566358 Opened 2 months ago Closed 10 days ago

Update releases page to include 64-bit Windows and Linux platforms

Categories

(SeaMonkey :: Website, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(23 files, 3 obsolete files)

56.24 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
6.37 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
5.01 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
3.99 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
877 bytes, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
29.15 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
86.23 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
1.70 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
854 bytes, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
1.49 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
792 bytes, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
822 bytes, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
59.98 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
3.65 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
2.73 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
5.13 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
26.72 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
40.34 KB, patch
frg
: review+
Details | Diff | Splinter Review
13.79 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
24.07 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
11.85 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
25.95 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
20.63 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review

At the moment release pages only cater for multiple locales on 32-bit Windows and Linux and this needs to be extended to include 64-bit Windows and Linux.

Comment on attachment 9078346 [details] [diff] [review]
New files to test changes [Checked in: Comment 2]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/3e2163499b20a8ff524ea4f06b5e05ea27c4b85b
Attachment #9078346 - Attachment description: New files to test changes → New files to test changes [Checked in: Comment 2]
Attachment #9078346 - Flags: review+
Attached patch Fix typos and coding (obsolete) — Splinter Review
Attachment #9078414 - Flags: review+
Attached patch Fix typos and coding v2 (obsolete) — Splinter Review
Attachment #9078414 - Attachment is obsolete: true
Attachment #9078422 - Flags: review+

Set class on download link too

Attachment #9078422 - Attachment is obsolete: true
Attachment #9078429 - Flags: review+
Comment on attachment 9078429 [details] [diff] [review]
Fix typos and coding v3 [Checked in: Comment 6]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/467bb35d69dff460a1b4a7c782f973a6b6f24ba5
Attachment #9078429 - Attachment description: Fix typos and coding v3 → Fix typos and coding v3 [Checked in: Comment 6]
Attachment #9078477 - Flags: review+
Comment on attachment 9078477 [details] [diff] [review]
Styling for new index [Checked in: Comment 8]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/be325f40029be1e026f69b79fa08c15a5282eeda
Attachment #9078477 - Attachment description: Styling for new index → Styling for new index [Checked in: Comment 8]
Depends on: 1566647
Comment on attachment 9079612 [details] [diff] [review]
Fix divs and add more styling [Checked in: Comment 10]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/1b8b5d93c7725af3bab1addc417f2f25cc9aab22
Attachment #9079612 - Attachment description: Fix divs and add more styling → Fix divs and add more styling [Checked in: Comment 10]
Comment on attachment 9079613 [details] [diff] [review]
Fix width of download box [Checked in: Comment 12]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/ac6ca3d1b39ca1da3e0d0a664981bcb00a3e38eb
Attachment #9079613 - Attachment description: Fix width of download box → Fix width of download box [Checked in: Comment 12]

Lots of duplication between this and the releases page (though mostly hidden).

Attachment #9079614 - Flags: review+
Comment on attachment 9079614 [details] [diff] [review]
Updated download section of home page [Checked in: Comment 14]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/e8b0dec072d95da5bb752e4c7530d4e489994209
Attachment #9079614 - Attachment description: Updated download section of home page → Updated download section of home page [Checked in: Comment 14]

There is no point having the same generic title on every entry in the table so remove them and use a single attribute elsewhere.

Attachment #9079629 - Flags: review+
Comment on attachment 9079629 [details] [diff] [review]
Remove duplication in titles [Checked in: Comment 16]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/250b52ccc680c1bc1dd7dfebd6e535eddcbd7c2e
Attachment #9079629 - Attachment description: Remove duplication in titles → Remove duplication in titles [Checked in: Comment 16]

Table footers need to take account of 8 rather than 6 columns.

Attachment #9079630 - Flags: review+
Comment on attachment 9079630 [details] [diff] [review]
Fix table footers [Checked in: Comment 18]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/b13a06575bfd36877f356bdbbf7412e90bd9cba7
Attachment #9079630 - Attachment description: Fix table footers → Fix table footers [Checked in: Comment 18]

As ewong pointed out, was missing a couple of variables so not being processed properly.

Attachment #9079683 - Flags: review+
Comment on attachment 9079683 [details] [diff] [review]
Fix new home page [Checked in: Comment 20]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/461d74724705a068eea9500d5dad1b116840c4d5
Attachment #9079683 - Attachment description: Fix new home page → Fix new home page [Checked in: Comment 20]

Missed the change to JS to update download link title from data-title attribute.

Attachment #9079686 - Flags: review+
Comment on attachment 9079686 [details] [diff] [review]
Fix title JS [Checked in: Comment 22]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/f43cf008a42fe7729adb001045e41f45a467dddc
Attachment #9079686 - Attachment description: Fix title JS → Fix title JS [Checked in: Comment 22]

On the home page there was too much green space below the bullet points on the download now box.

Attachment #9079692 - Flags: review+
Comment on attachment 9079692 [details] [diff] [review]
Fix Green Space [Checked in: Comment 24]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/3f0c7f3d09b3503237d9e0f483e24e980ff82be3
Attachment #9079692 - Attachment description: Fix Green Space → Fix Green Space [Checked in: Comment 24]

There's not a big enough margin below the download box on the homepage which means some of the text almost overruns the key-point box.

Attachment #9079704 - Flags: review+
Attachment #9079704 - Attachment description: Fix margin on homepage download box → Fix margin on homepage download box [Checked in: Comment 26]

Rather than repeating the same code across multiple HTML pages, make use of the templates with XML sources for the data.

Attachment #9080402 - Flags: review+
Comment on attachment 9080402 [details] [diff] [review]
Use xml source for downloads table and fieldset [Checked in: Comment 28]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/d828626954167b59f9e35b01497c14893b0cf0a2
Attachment #9080402 - Attachment description: Use xml source for downloads table and fieldset → Use xml source for downloads table and fieldset [Checked in: Comment 28]

Switch to using x64/x32 instead of 64-bit/32-bit
Fix issue with key-point divs being too short.

Attachment #9080417 - Flags: review+
Comment on attachment 9080417 [details] [diff] [review]
Switch from bit [Checked in: Comment 30]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/b13d1e95b37f724df3614690f5a7d8742dc0f9cd
Attachment #9080417 - Attachment description: Switch from bit → Switch from bit [Checked in: Comment 30]

Accidentally missed out the <p> tags from the fieldset XML conversion

Attachment #9080419 - Flags: review+
Comment on attachment 9080419 [details] [diff] [review]
Fix fieldset [Checked in: Comment 32]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/695b12b2d39a2c4bf99ee2fd84b87becbb9ad69f
Attachment #9080419 - Attachment description: Fix fieldset → Fix fieldset [Checked in: Comment 32]

Allow the table footer to be defined by XML too
Remove unneeded class from 6th column heading
Correct order of languages in table

Attachment #9080496 - Flags: review+
Comment on attachment 9080496 [details] [diff] [review]
Table footer by XML [Checked in: Comment 34]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/5b9d4df758df791e51e8bc3056271a2a38c143e4
Attachment #9080496 - Attachment description: Table footer by XML → Table footer by XML [Checked in: Comment 34]

Moves JS into separate file so it can be shared with other start pages
Restructures divs so there is only one download box
Switches new page to use XML source for table and fieldset

Attachment #9080497 - Flags: review+
Comment on attachment 9080497 [details] [diff] [review]
New start page [Checked in: Comment 36]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/11294894620ca55b7bd27982f8f28375aa62ede7
Attachment #9080497 - Attachment description: New start page → New start page [Checked in: Comment 36]
Attached patch New de start page (obsolete) — Splinter Review

New de page that:

  • Uses common JS rather than its own copy
  • Restructures divs so there is a single download box
  • Uses localised XML sources to provide table and fieldset

All localisation additions need a native speaker to review as the internet is not the best at translating strings.

In theory other de pages could be created (release / home) using the same localised XML sources.

Attachment #9080500 - Flags: review?(frgrahl)

Fixed an issue I found with CSS and a missing table column

Attachment #9080500 - Attachment is obsolete: true
Attachment #9080500 - Flags: review?(frgrahl)

Fixes for:

  • Missing column version in XML cannot be set to "" so set to "ver"
  • CSS for start page's congratulations div needs adjusting for size of SM logo
Attachment #9080504 - Flags: review+
Comment on attachment 9080504 [details] [diff] [review]
New fixes [Checked in: Comment 40]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/346487c302f4432f0e4e5f264553111945707ad4
Attachment #9080504 - Attachment description: New fixes → New fixes [Checked in: Comment 40]
Attachment #9080502 - Flags: review?(frgrahl)
Comment on attachment 9080502 [details] [diff] [review]
New de start page v1.1 [Checked in: Comment 42]

Review of attachment 9080502 [details] [diff] [review]:
-----------------------------------------------------------------

> SeaMonkey-Builds können heruntergeladen werden.

Looks good. Thinking about changing the above string later but it is correct. Just sounds a little "wooden". But can go in.
Attachment #9080502 - Flags: review?(frgrahl) → review+
Comment on attachment 9080502 [details] [diff] [review]
New de start page v1.1 [Checked in: Comment 42]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/c1b28e5cb28d4de5894d51cb829834e5637b14ae
Attachment #9080502 - Attachment description: New de start page v1.1 → New de start page v1.1 [Checked in: Comment 42]
Comment on attachment 9083745 [details] [diff] [review]
Switch 2.49.4 to use xml file for table [Checked in: Comment 44]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/ac867cc736a5e57be3b1c5c1ef15d0797fdc2178
Attachment #9083745 - Attachment description: Switch 2.49.4 to use xml file for table → Switch 2.49.4 to use xml file for table [Checked in: Comment 46]
Comment on attachment 9083752 [details] [diff] [review]
Switch releases index to use XML file for table [Checked in: Comment 46]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/c562d3eaecd32bed4989d1161b532f8e16383d34
Attachment #9083752 - Attachment description: Switch releases index to use XML file for table → Switch releases index to use XML file for table [Checked in: Comment 48]
Comment on attachment 9083803 [details] [diff] [review]
Update de and en start pages [Checked in: Comment 48]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/69d5313b0ed2d0014e5807608240af50b2fc3e0e
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/1de2368f8285dbc75ab0a21601ad304043f159bc
Attachment #9083803 - Attachment description: Update de and en start pages → Update de and en start pages [Checked in: Comment 50]

Some very old release pages have green download boxes, these are not needed any more.

Attachment #9083824 - Flags: review+
Attachment #9083803 - Attachment description: Update de and en start pages [Checked in: Comment 50] → Update de and en start pages [Checked in: Comment 48]
Comment on attachment 9083824 [details] [diff] [review]
Remove old green download boxes [Checked in: Comment 50]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/f2f39562e05c7705db2af1409229c3ac0fd4a4e8
Attachment #9083824 - Attachment description: Remove old green download boxes → Remove old green download boxes [Checked in: Comment 50]
Attachment #9083752 - Attachment description: Switch releases index to use XML file for table [Checked in: Comment 48] → Switch releases index to use XML file for table [Checked in: Comment 46]
Attachment #9083745 - Attachment description: Switch 2.49.4 to use xml file for table [Checked in: Comment 46] → Switch 2.49.4 to use xml file for table [Checked in: Comment 44]

SeaMonkey 2.49.5 was released and this all seems to work fine. Thanks to all involved especially to IanN for redoing the templates.

Status: ASSIGNED → RESOLVED
Closed: 10 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.