1566443 - Rename aboutdebugging-new to aboutdebugging

Status: RESOLVED FIXED

(DevTools :: about:debugging, task, P3)

Description

[Julian Descottes [:jdescottes]]

After removing the old aboutdebugging in bug 1539461, we can rename the aboutdebugging-new folder to aboutdebugging. We should do that just before the soft freeze for 70 (2019-08-26) in order to minimize potential uplift issues.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1566443 - Rename folder aboutdebugging-new to aboutdebugging

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab25abaafa1b
Rename folder aboutdebugging-new to aboutdebugging r=remote-debugging-reviewers,daisuke

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset ab25abaafa1b (Bug 1566443) for es lint failure on helper-addons.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=f41a0d88947089263d3a636ee31d278e6117c5ae&tochange=d8038c9cac36f9a27412e11d6311c8d89d2b821e&selectedJob=263083903

Backout link: https://hg.mozilla.org/integration/autoland/rev/d8038c9cac36f9a27412e11d6311c8d89d2b821e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263083903&repo=autoland&lineNumber=226

[task 2019-08-23T07:41:41.877Z] building 'psutil._psutil_posix' extension
[task 2019-08-23T07:41:41.877Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-08-23T07:41:41.877Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-08-23T07:41:41.877Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2019-08-23T07:41:41.877Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-08-23T07:41:41.877Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-08-23T07:41:41.877Z]
[task 2019-08-23T07:41:41.877Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-08-23T07:54:27.545Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/aboutdebugging/test/browser/helper-addons.js:31:22 | Promise executor functions should not be async. (no-async-promise-executor)
[taskcluster 2019-08-23 07:54:28.111Z] === Task Finished ===
[taskcluster 2019-08-23 07:54:28.952Z] Unsuccessful task run with exit code: 1 completed in 1021.795 seconds

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f25f7188eaff
Rename folder aboutdebugging-new to aboutdebugging r=remote-debugging-reviewers,daisuke

Comment 5

[Julian Descottes [:jdescottes]]

Thanks Bogdan! Had to update an eslintrc path pointing to aboutdebugging-new that was added yesterday in Bug 1551829.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f25f7188eaff