update to manifest with incognito.not_allowed does not remove permission
Categories
(WebExtensions :: General, defect, P1)
Tracking
(firefox70 fixed)
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
Attachments
(1 file)
If an extension is spanning and the user grants permission to private browsing, then the extension is updated to a version where the manifest declares not_allowed, we do not remove permission.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=78eb74274c6d0b8ef86b5070d12f31cb329c3cfd
Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae5badd3b49e remove permission if extension updates to incognito.now_allowed r=robwu,rpl
Comment 5•4 years ago
|
||
bugherder |
Comment 6•4 years ago
|
||
Hello,
I've attempted to test this by installing on Firefox 70.0a1(20190829214656) an older version of the HTTP Everywhere extension (https://addons.mozilla.org/en-US/firefox/addon/https-everywhere/versions/), downloading and modifying the most recent version's manifest by setting incognito=not_allowed, and then updating the installed version through drag and drop of the modified newer version.
The extension permission from about:addons> HTTP Everywhere> Details showed that it was still allowed to "Run in Private Windows".
So far I am not sure what other method to use to test this.
If this fix requires manual validation please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!
Assignee | ||
Comment 7•4 years ago
|
||
Not sure what to say, but I just did a similar test with just a simple extension and the permission was removed as expected. This is also covered by automated tests, so given all that, I'll qe-
Description
•