1566627 - add classification flags to proxy.onRequest

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement, P1)

Description

[Shane Caraveo (:mixedpuppy)]

Moving the webext part of this work to its own bug. Originally from bug 1563313.

Supporting this at the webextension layer is simple, but currently proxy is resolved in httpchannel prior to classification, so there is no classification data available at the right time.

baku has a patch in bug 1531814 that changed this, we can pull out the httpchannel changes to address this.

targeting fx70 for secure-proxy

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1566627 support classification in proxy.onRequest

Add trackingClassification to the details object for proxy.onRequest.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1566627 - Fix intermittent failures in test_ext_webrequest_tracking.html, r?mixedpuppy

Depends on D37162

Comment 3

[Phabricator Automation]

Comment on attachment 9078539 [details]
Bug 1566627 - Fix intermittent failures in test_ext_webrequest_tracking.html, r?mixedpuppy

Revision D37163 was moved to bug 1547140. Setting attachment 9078539 [details] to obsolete.

Comment 4

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c910d2b9ff23c0b3d1adeaa6e0a629e0a5142cf5

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1d277f774ca
support classification in proxy.onRequest r=zombie

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b1d277f774ca

Comment 7

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!