156679 - Can't open image link in new window

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[Mike Pinkerton (not reading bugmail)]

For any image that's also a link, the context menu item "Open In New Window"
tosses up an exception dialog in PPEmbed. The reason is because the dom node for
the context menu is the <IMAGE> tag, not the <A>, so it can't be QI'd to
nsIDOMHTMLAnchorElement.

Should be relatively easy to fix, just walk up the parent chain until you find
the anchor.

Comment 1

[Mike Pinkerton (not reading bugmail)]

we should probably fix this for 1.01 for embedding clients (note, chimera does
not have this problem).

Comment 2

[Michael Dunn]

Does this affect other Clients (N7, Win32 Embedding?)

Comment 3

[Mike Pinkerton (not reading bugmail)]

nope, only ppembed, and in fact, it's already been fixed by the main client we
would care about...not that they would, oh, give us a patch or anything.
hmmmmmmmmmm? ;)

removing topembed, though we should still fix this.

Comment 4

[saari (gone)]

while not technically a blocker yet, I've added it to the blockers list. Sounds
like the kind of thing that could become a blocker...

Comment 5

[Michael Dunn]

--> Adding Embed

Comment 6

[Steve Dagley]

Removing as blocker for 150045 as cough, cough, already has a fix in their tree

Comment 7

[Conrad Carlen (not reading bugmail)]

Attachment: patch

Simple patch which, on finding out that the DOM node is not a link element
(though it's been told by the flags that it is), goes up the parent chain to
find a link element. Note that it's only done for images. In this case, the
flags tell us that it's both an image and a link.

Comment 8

[Conrad Carlen (not reading bugmail)]

This was fixed by bug 157786 which incorporated this patch.

Comment 9

[Michael Dunn]

to Dharma for verification

Comment 10

[dsirnapalli]

-- verified on latest branch(2002-10-09-05-1.0) and latest
trunk(2002-10-10-08-trunk) of PPEmbed. I am able to open image link in new
window using context menu. Marking the bug verified.