1566813 - [Protections Panel] Show a notSecure icon if it is an about:certerror page

Status: RESOLVED FIXED

(Firefox :: Site Identity, task, P3)

Comment 1

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Attachment: Bug 1566813 - Part 1: Divide gIdentityHandler.refreshIdentityBlock(). r?johannh!

Right now, the gIdentityHandler.refreshIdentityBlock() is gigantic. In
order to not hit the eslint assert 'complexity', we segregate this
function into two functions according to the functionalities. This
slightly improves the readability of this function.

Comment 2

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Attachment: Bug 1566813 - Part 2: Show a warning lock icon as the identity icon if it is in a 'about:certerror' page. r?johannh!

This patch adds a new class 'certError' for the identity icon if it is
in the 'about:certerror' page. The identity icon will show a warning
lock icon if this class is present.

Depends on D45645

Comment 3

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Attachment: Bug 1566813 - Part 3: Show a warning lock icon for the 'about:certerror' page in identity popup. r?johannh!

We add a new connection type 'cert-error-page' and will show a warning
lock icon for it.

Depends on D45646

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/605c42da4f23
Part 1: Divide gIdentityHandler.refreshIdentityBlock(). r=johannh
https://hg.mozilla.org/integration/autoland/rev/9d2a58664ef2
Part 2: Show a warning lock icon as the identity icon if it is in a 'about:certerror' page. r=johannh
https://hg.mozilla.org/integration/autoland/rev/b2132eecf8d0
Part 3: Show a warning lock icon for the 'about:certerror' page in identity popup. r=johannh

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/605c42da4f23
https://hg.mozilla.org/mozilla-central/rev/9d2a58664ef2
https://hg.mozilla.org/mozilla-central/rev/b2132eecf8d0