Closed Bug 1566813 Opened 4 months ago Closed 2 months ago

[Protections Panel] Show a notSecure icon if it is an about:certerror page

Categories

(Firefox :: Site Identity, task, P3)

task

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: timhuang, Assigned: timhuang)

References

(Blocks 1 open bug)

Details

(Whiteboard: [skyline])

Attachments

(3 files)

No description provided.
Priority: -- → P3
Whiteboard: [privacy-panel][triage] → [skyline]
Assignee: nobody → tihuang
Status: NEW → ASSIGNED

Right now, the gIdentityHandler.refreshIdentityBlock() is gigantic. In
order to not hit the eslint assert 'complexity', we segregate this
function into two functions according to the functionalities. This
slightly improves the readability of this function.

This patch adds a new class 'certError' for the identity icon if it is
in the 'about:certerror' page. The identity icon will show a warning
lock icon if this class is present.

Depends on D45645

We add a new connection type 'cert-error-page' and will show a warning
lock icon for it.

Depends on D45646

Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/605c42da4f23
Part 1: Divide gIdentityHandler.refreshIdentityBlock(). r=johannh
https://hg.mozilla.org/integration/autoland/rev/9d2a58664ef2
Part 2: Show a warning lock icon as the identity icon if it is in a 'about:certerror' page. r=johannh
https://hg.mozilla.org/integration/autoland/rev/b2132eecf8d0
Part 3: Show a warning lock icon for the 'about:certerror' page in identity popup. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.