1566875 - Ship WebRender on Laptop Nvidia with small screen (<= 1920x1200)

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, task, P2)

Description

[Jessie [:jbonisteel] pls NI]

We'd like to ship WebRender on Nvidia Laptops with small screens (<= 1920x1200) with 71

Comment 1

[Pascal Chevrel:pascalc]

Tracking for 71 as the target release.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1566875 - Allow WebRender to be qualified on Windows/NVIDIA/laptop/small screens.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

This is getting bumped to 72. Because of the following lines:

https://searchfox.org/mozilla-beta/rev/8330ececd4e18c759ce4bf99fac0813d22b1cd09/gfx/thebes/gfxPlatform.cpp#2935
https://searchfox.org/mozilla-beta/rev/8330ececd4e18c759ce4bf99fac0813d22b1cd09/gfx/thebes/gfxPlatform.cpp#3007

We never actually enabled this on 71 beta in the first place. As such, it is probably best to defer to 72.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4279ebeb54cd
Allow WebRender to be qualified on Windows/NVIDIA/laptop/small screens. r=jrmuizel

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/4279ebeb54cd

Comment 7

[Jeff Muizelaar [:jrmuizel]]

We're going to back this out of beta to minimize risk.

Comment 8

[Jessie [:jbonisteel] pls NI]

We have decided to not ship this target for 72. We are monitoring some UI glitches we are seeing reports of and want to avoid shipping WebRender further until we have a better understanding of what is causing those bugs. Metabug for tracking those glitches: https://bugzilla.mozilla.org/show_bug.cgi?id=1604492

Comment 9

[Julien Cristau [:jcristau]]

Does that mean we need to land a patch in tree or is that remotely controlled?

Comment 10

[Julien Cristau [:jcristau]]

(In reply to Julien Cristau [:jcristau] from comment #9)

Does that mean we need to land a patch in tree or is that remotely controlled?

Jeff or Jessie can you confirm whether this requires a respin of the release candidate build vs a normandy pref rollout?

Comment 11

[Jeff Muizelaar [:jrmuizel]]

This will require a respin.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

I was considering making a more targeted patch to do this but the safest thing might be to just back out https://hg.mozilla.org/mozilla-central/rev/4279ebeb54cd on the release branch. Julien can you cause this?

Comment 13

[Julien Cristau [:jcristau]]

Backout patch:
https://hg.mozilla.org/releases/mozilla-release/rev/d88c5f2e59dccf2bfd345e66e548f2f245561a00

Comment 14

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 73.0a1 (2020-01-03).