1566906 - Picture-in-Picture toggle should not open PiP except on primary mouse click

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

On a build with Picture-in-Picture enabled:

1. Go to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video
2. Hit the Play button on the video
3. Hover the mouse over the video so that the Picture-in-Picture toggle button is displayed
4. Right-click on the Picture-in-Picture toggle button

ER:

Nothing.

AR:

The Picture-in-Picture player window opens.

We should only pay attention to primary (left) mouse clicks.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1566906 - Make Picture-in-Picture toggle only listen for clicks from the primary mouse button. r?JSON_Voorhees

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18a84c6f3392
Make Picture-in-Picture toggle only listen for clicks from the primary mouse button. r=JSON_voorhees

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/18a84c6f3392

Comment 4

[Timea Cernea [:tbabos][inactive]]

Verified - Fixed on latest Firefox Beta 70.0b6 (64-bit) on Windows 10 x64. - using media.videocontrols.picture-in-picture.video-toggle.enabled true

Right-clicking the toggle will open the context menu with the "Hide Picture-in-Picture Toggle" but will not open the video in PiP.
Also updating flags.