Closed Bug 1566906 Opened Last month Closed Last month

Picture-in-Picture toggle should not open PiP except on primary mouse click

Categories

(Toolkit :: Video/Audio Controls, defect, P2)

68 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STR:

On a build with Picture-in-Picture enabled:

  1. Go to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video
  2. Hit the Play button on the video
  3. Hover the mouse over the video so that the Picture-in-Picture toggle button is displayed
  4. Right-click on the Picture-in-Picture toggle button

ER:

Nothing.

AR:

The Picture-in-Picture player window opens.

We should only pay attention to primary (left) mouse clicks.

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18a84c6f3392
Make Picture-in-Picture toggle only listen for clicks from the primary mouse button. r=JSON_voorhees
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.