156695 - MailNews support for Windows XP SP1

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[Jaime Rodriguez, Jr.]

This is track the MailNews work needed to support Windows XP SP1.

Pls supply the following:
1. An estimate of engineering and QA person days required to implement this
request in the Status Whiteboard
2. Minimum Design Specificaiton (as an attachement)
3. Test Case (as an attachement)

Comment 1

[scottputterman]

reassigning to ssu.

Comment 2

[Sean Su]

Attachment: patch v1.0

this patch will add new cmdline option to mozilla.exe:
 -setDefaultMail
 -unsetDefaultMail

it will preserve the previous state that mozilla.exe was in, either leave it
running if it was running, or quit if it was not running.

It works with turbo feature too.  If it was in turbo mode without any windows
open, it will leave it in that state when it's done.

testing scenarios for browser not running, running in non-turbo mode, and
running in turbo mode:
  mozilla.exe -setDefaultMail
  mozilla.exe -unsetDefaultMail

you can check the prefs after it's run to see if it worked.

I'm still testing the patch to see where I need to also update in packages-win,
but wanted to put this patch out for now.

Comment 3

[Sean Su]

Attachment: patch v1.1

this is a better patch.  this patch is dependent on Bill Law's patch in bug
156698.

Comment 4

[Bill Law]

Comment on attachment 91084 [details] [diff] [review]
patch v1.1

r=law

Comment 5

[Scott MacGregor]

Comment on attachment 91084 [details] [diff] [review]
patch v1.1

I noticed this code is in xpfe/components/winhooks.

What happens if mail isn't installed? Does this code get executed?

Should this code be moved to the mailnews module or does it have to in
winhooks?

Comment 6

[Sean Su]

Per Rajiv, if mail is not installed, the code (in nsSetDefaultMail.js and
nsUnsetDeaultMail.jst) is harmless.

also forgot to attach the patch to packages-win so that it'll get packaged up
with the browser.xpi file:

Index: packages-win
===================================================================
RCS file: /cvsroot/mozilla/xpinstall/packager/packages-win,v
retrieving revision 1.207.2.9
diff -u -r1.207.2.9 packages-win
--- packages-win        28 Jun 2002 00:22:12 -0000      1.207.2.9
+++ packages-win        13 Jul 2002 04:26:32 -0000
@@ -264,6 +264,8 @@
 bin\components\transformiix.dll
 bin\ISimpleDOMNodeMarshal.dll
 bin\ISimpleDOMDocumentMarshal.dll
+bin\components\nsSetDefaultMail.js
+bin\components\nsUnsetDefaultMail.js

Comment 7

[Scott MacGregor]

It may be harmless, I'm just asking if we think it belongs there or if it
belongs in a mailnews module? This is a new file we are adding right? 

Comment 8

[Sean Su]

gotcha.  I just moved it to the mail section in packages-win.  it'll get
installed with mail.xpi now.  so if the .js files are not there and we try the
command line -setDefaultMail/-unsetDefaultMail, nothing should happen.

Diff for packages-win now looks like (sorry I can't attach a clean patch.  got
too much stuff in my tree right now):
Index: packages-win
===================================================================
RCS file: /cvsroot/mozilla/xpinstall/packager/packages-win,v
retrieving revision 1.207.2.9
diff -u -r1.207.2.9 packages-win
--- packages-win  28 Jun 2002 00:22:12 -0000  1.207.2.9
+++ packages-win  16 Jul 2002 01:37:51 -0000
@@ -385,6 +385,8 @@
 bin\components\msgmdn.dll
 bin\components\msgmdn.xpt
 bin\components\mdn-service.js
+bin\components\nsSetDefaultMail.js
+bin\components\nsUnsetDefaultMail.js

 [chatzilla]
 bin\components\chatzilla-service.js

Comment 9

[Scott MacGregor]

Comment on attachment 91084 [details] [diff] [review]
patch v1.1

thanks sean!

sr=mscott

Comment 10

[[e-mail]]

Comment on attachment 91084 [details] [diff] [review]
patch v1.1

You might want to correct some comments e.g. "The Original Code is Mozilla Kill
All."

Comment 11

[Sean Su]

Attachment: patch v1.1.1

minor update (comments cleanup as suggested by neil)

Comment 12

[Sean Su]

Comment on attachment 91659 [details] [diff] [review]
patch v1.1.1

moving r=, sr= to here since it's only a comment change.

I've also included the packages-win diff in the latest patch.

Comment 13

[scottputterman]

adding adt1.0.1+.  Please get drivers approval before checking in.

Comment 14

[Sean Su]

patches checked in to the BRANCH only.  I'm closing this bug because it was only
referring to the branch.  I'll open a new bug to have these patches checked into
the TRUNK.

Comment 15

[Trix Supremo]

build: 20020722 branch
OS: Microsoft XP Professional Build 2600.xpsp1.020529-1810 (Service Pack 1, v.1050)

verification of mail client has been complete with resulted posted on testcases
linked below.  changing keyword to verified1.0.1

testcases can be found at:

http://mrbolo.mcom.com/xpsp1/xpsp1.html

Comment 16

[Trix Supremo]

testcases have now been postedon slip:

http://slip.mcom.com/client/mailnews/MachV/bug156695.html