Closed Bug 1567053 Opened 6 years ago Closed 6 years ago

Make default ::-moz-focus-inner border color more accessible

Categories

(Core :: DOM: CSS Object Model, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: ntim, Assigned: ntim)

Details

Attachments

(3 files)

Attached image Before applying patch

Right now, the default border color is ButtonText (which is black on most platforms default themes) which is inaccessible when the button background is dark.

I've noticed this while tabbing through the new about:addons details view tabs. As the screenshot shows, the focusring around "Permissions" is hard to see.

I think we could change this to be currentColor would be a lot more accessible IMO (and this was probably the original intent since currentColor wasn't a thing at that time).

Fun fact: annotate shows that I was six-months old when the rule as it is today was added 😅

https://searchfox.org/mozilla-central/diff/3b93ffe84819ca54b2e2be7ae9af780ed6f46bdf/layout/style/html.css#704

Attached image After applying patch
Attachment #9078946 - Attachment description: image.png → Before applying patch
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d89f406b0fd1 Make default ::-moz-focus-inner border color more accessible. r=bzbarsky
Assignee: nobody → ntim.bugs
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: