156732 - Referrer not set when opening links in new window

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Mike Pinkerton (not reading bugmail)]

- go to above page (caution, it's pr0n and may even disappear w/in a few days)
- cmd-click or use context menu to open any of the thumbnails in a new window

expected:
image appears in new window

actual:
because the referrer is not set, the webserver redirects you to a "not found" page.

i have a patch, upcoming. i need some eagle-eyed reviews on this because i think
it should go in asap and i don't want to screw anything up. I've checked the
warnings when building for unknown methods and i think i got everything, but you
know cocoa....

Comment 1

[Mike Pinkerton (not reading bugmail)]

Attachment: teach chimera about referrer

teach chimera about referrer.

can i get a good once-over on this patch before we land it?

Comment 2

[Steve Smart]

*** Bug 156730 has been marked as a duplicate of this bug. ***

Comment 3

[Simon Fraser [no longer active]]

The patch looks OK. Mike is responding to some comments over AIM.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Attachment: updated patch with new param names/ordering

just updated the param names and order to match what smfr and i discussed.
nothing else changed.

Comment 5

[Simon Fraser [no longer active]]

Comment on attachment 90848 [details] [diff] [review]
updated patch with new param names/ordering

r=sfraser

Comment 6

[Mike Pinkerton (not reading bugmail)]

landed.

Comment 7

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.07.11.05 nb.

ran the following tests:

* the test url here (new tab, new window, cmd+click)
* loading bookmarks (menu, sidebar)
* URLbar
* launching from an external app (eg, Mail), in new window and new tab
* various links in web pages (new tab, new window, cmd+click)

let me know if there are other areas you'd like me to check.