1567390 - Add tests to catch Profiler stack-sampling regressions

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Bug 1567236 describes a stack sampling regression caused by bug 1557282.
It's a bit embarrassing that it took a whole week to be reported!

It would be good to have minimal testing that can detect such regressions ASAP.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1567390 - Add a stackwalking test to the profiler; r?canaltinova

Comment 2

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f98a01502370f6b886c6f568c74a853ab953d39d

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1567390 - Add a JS stack collection test; r?canaltinova

Depends on D40308

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1567390 - Add a merged stack test for the profiler; r?canaltinova

Depends on D40324

Comment 5

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=22209164df8058caba1cb976ab0bd99f60293384

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ab1565e5900
Add a stackwalking test to the profiler; r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/9527800a8dcd
Add a JS stack collection test; r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/9655b89e5f5a
Add a merged stack test for the profiler; r=canaltinova

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/6ab1565e5900
https://hg.mozilla.org/mozilla-central/rev/9527800a8dcd
https://hg.mozilla.org/mozilla-central/rev/9655b89e5f5a