"Tracking Protections" doesn't have pressing effect
Categories
(Firefox :: Site Identity, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox68 | --- | unaffected |
| firefox69 | --- | unaffected |
| firefox70 | --- | verified |
People
(Reporter: Virtual, Assigned: timhuang)
References
Details
(Keywords: nightly-community, ux-consistency, Whiteboard: [skyline])
Attachments
(8 files)
no bug - no hovering effect.png
STR:
- Keep pressing "Tracking Protections"
and see that it doesn't have pressing pressing effect like other items in bars.
It only shows itself after "Tracking Protections" menu will be completely visible.
|
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
|
Comment 7•5 years ago
|
||
Compare attachments from:
- Comment #2 => Comment #4 = no change (effect should be same as in Comment #6)
to: - Comment #3 => Comment #5 = change
|
|
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
|
Updated•5 years ago
|
|
||
Comment 8•5 years ago
•
|
||
Using the dark theme:
Background of padlock is brighter on mouse down (and when the identity panel is open) than when hovering.
Background of TP icon is only brigther when TP panel is open. It should be brigther on mouse down, too.
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 9•5 years ago
|
||
This patches fixes this issue by adding a missing css rule for the
pressing effect.
|
|
Assignee | |
Comment 10•5 years ago
|
||
This patch moves the setting of 'open' attribute to a right place. We
should set it before we open the panel instead of in the event
'onpopupshown'.
Depends on D39494
|
||
Comment 11•5 years ago
|
||
Pushed by tihuang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c0bc0b959a4 Part 1: Fix the issue that tracking protection icon doesn't have pressing effect. r=johannh https://hg.mozilla.org/integration/autoland/rev/4580b16fa5ee Part 2: Fixing the issue that hover state of the tracking protection icon is incorrect during opening the protection panel. r=johannh
|
||
Comment 12•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2c0bc0b959a4
https://hg.mozilla.org/mozilla-central/rev/4580b16fa5ee
|
|
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
|
Comment 13•5 years ago
|
||
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 70.0a1 (2019-07-30), so I'm marking this bug as VERIFIED.
Thank you very much! \o/
Description
•