1567433 - "Tracking Protections" doesn't have pressing effect

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

STR:

1. Keep pressing "Tracking Protections"
   and see that it doesn't have pressing pressing effect like other items in bars.

It only shows itself after "Tracking Protections" menu will be completely visible.

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug - no hovering effect.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug - hovering effect over Tracking Protections.png

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug - hovering effect over Site Information.png

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug - pressing effect over Tracking Protections.png

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug - pressing effect over Site Information.png

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug - pressing effect with Tracking Protections menu.png

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Compare attachments from:

• Comment #2 => Comment #4 = no change (effect should be same as in Comment #6)
  to:
• Comment #3 => Comment #5 = change

Comment 8

[Darkspirit]

Using the dark theme:
Background of padlock is brighter on mouse down (and when the identity panel is open) than when hovering.
Background of TP icon is only brigther when TP panel is open. It should be brigther on mouse down, too.

Comment 9

[Tim Huang[:timhuang]]

Attachment: Bug 1567433 - Part 1: Fix the issue that tracking protection icon doesn't have pressing effect. r?johannh!

This patches fixes this issue by adding a missing css rule for the
pressing effect.

Comment 10

[Tim Huang[:timhuang]]

Attachment: Bug 1567433 - Part 2: Fixing the issue that hover state of the tracking protection icon is incorrect during opening the protection panel. r?johannh!

This patch moves the setting of 'open' attribute to a right place. We
should set it before we open the panel instead of in the event
'onpopupshown'.

Depends on D39494

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c0bc0b959a4
Part 1: Fix the issue that tracking protection icon doesn't have pressing effect. r=johannh
https://hg.mozilla.org/integration/autoland/rev/4580b16fa5ee
Part 2: Fixing the issue that hover state of the tracking protection icon is incorrect during opening the protection panel. r=johannh

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2c0bc0b959a4
https://hg.mozilla.org/mozilla-central/rev/4580b16fa5ee

Comment 13

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 70.0a1 (2019-07-30), so I'm marking this bug as VERIFIED.
Thank you very much! \o/