1567457 - Update cubeb-pulse-rs to version 3a748a2

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P1)

Description

[Paul Adenot (:padenot)]

This includes the following commits:

3a748a2 Run the PulseAudio callbacks from the output
836c1dc Make pa_sample_size available in Rust.
e33cba0 Bump minimum Rust version to 1.35 to match Gecko beta version requirement.
a32febf Revert "Use std::mem::MaybeUninit instead of the deprecated std::mem::uninitialized"
9d1c129 Use std::mem::MaybeUninit instead of the deprecated std::mem::uninitialized
6f7c095 Use assert_eq instead of debug_assert_eq for safety-critical assertions.

The MaybeUninit part has been reverted for now and will land in bug 1563877.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1567457 - Update cubeb-pulse-rs to version ee6666. r?kinetik

Reviewed upstream by :achronop, :kinetik, :chunmin in:
https://github.com/djg/cubeb-pulse-rs/pull/41
https://github.com/djg/cubeb-pulse-rs/pull/42

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1567457 - Vendor rust depencies: add ringbuf. r?kinetik

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35503df3d3e8
Update cubeb-pulse-rs to version 3a748a2. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/ce5d76c8be1b
Vendor rust depencies: add ringbuf. r=kinetik

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5394db272ad1
Backed out 2 changesets for failures at test_getUserMedia_basicAudio_loopback.html on a CLOSED TREE.

Comment 5

[Paul Adenot (:padenot)]

Unfortunately, the input underruns too much, and provokes input glitches. I'm investigating.

Comment 6

[Raul Gurzau (:RaulG)]

Backed out 2 changesets (bug 1567457) for failures at test_getUserMedia_basicAudio_loopback.html on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/5394db272ad1f848f19ad15cc995dd8d85aa4c60

**Push with failures:**https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=ce5d76c8be1b2dca90f9e512c19d98b64c754fe0&selectedJob=257394662

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257394662&repo=autoland&lineNumber=13890

Log snippet:

[task 2019-07-19T14:32:06.121Z] 14:32:06 INFO - Analysing audio frequency - low:target:high = 160:255:128
[task 2019-07-19T14:32:06.124Z] 14:32:06 INFO - Buffered messages finished
[task 2019-07-19T14:32:06.137Z] 14:32:06 INFO - TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_getUserMedia_basicAudio_loopback.html | Error executing test: Error: Audio analysis timed out waitForAnalysisSuccess@https://example.com/tests/dom/media/tests/mochitest/head.js:203:26 ... @https://example.com/tests/dom/media/tests/mochitest/test_getUserMedia_basicAudio_loopback.html:49:20 ... asyncrunTestWhenReady/<@https://example.com/tests/dom/media/tests/mochitest/head.js:492:22 ... promise callbackrunTestWhenReady@https://example.com/tests/dom/media/tests/mochitest/head.js:492:6 ... @https://example.com/tests/dom/media/tests/mochitest/test_getUserMedia_basicAudio_loopback.html:18:27 ... promise callback*@https://example.com/tests/dom/media/tests/mochitest/test_getUserMedia_basicAudio_loopback.html:18:16 ...
[task 2019-07-19T14:32:06.138Z] 14:32:06 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:275:18
[task 2019-07-19T14:32:06.139Z] 14:32:06 INFO - runTestWhenReady/<@https://example.com/tests/dom/media/tests/mochitest/head.js:494:7
[task 2019-07-19T14:32:06.139Z] 14:32:06 INFO - promise callbackrunTestWhenReady@https://example.com/tests/dom/media/tests/mochitest/head.js:493:6
[task 2019-07-19T14:32:06.140Z] 14:32:06 INFO - @https://example.com/tests/dom/media/tests/mochitest/test_getUserMedia_basicAudio_loopback.html:18:27
[task 2019-07-19T14:32:06.140Z] 14:32:06 INFO - promise callback@https://example.com/tests/dom/media/tests/mochitest/test_getUserMedia_basicAudio_loopback.html:18:16
[task 2019-07-19T14:32:06.142Z] 14:32:06 ERROR - [SimpleTest.finish()] this test already called finish!
[task 2019-07-19T14:32:06.147Z] 14:32:06 INFO - GECKO(3601) | MEMORY STAT | vsize 20974909MB | residentFast 944MB
[task 2019-07-19T14:32:06.147Z] 14:32:06 INFO - TEST-UNEXPECTED-ERROR | dom/media/tests/mochitest/test_getUserMedia_basicAudio_loopback.html | called finish() multiple times
[task 2019-07-19T14:32:06.148Z] 14:32:06 INFO - TEST-INFO took 70724ms
[task 2019-07-19T14:32:06.148Z] 14:32:06 INFO - TEST-OK | dom/media/tests/mochitest/test_getUserMedia_basicAudio_loopback.html
[task 2019-07-19T14:32:06.150Z] 14:32:06 INFO - TEST-START | dom/media/tests/mochitest/test_getUserMedia_basicScreenshare.html
[task 2019-07-19T14:32:06.151Z] 14:32:06 INFO - GECKO(3601) | TEST DEVICES: Got loopback audio: Monitor of Null Output
[task 2019-07-19T14:32:06.156Z] 14:32:06 INFO - GECKO(3601) | TEST DEVICES: Got loopback video: Dummy video device (0x0000)
[task 2019-07-19T14:32:06.751Z] 14:32:06 INFO - GECKO(3601) | TEST DEVICES: Got loopback audio: Monitor of Null Output
[task 2019-07-19T14:32:06.752Z] 14:32:06 INFO - GECKO(3601) | TEST DEVICES: Got loopback video: Dummy video device (0x0000)
[task 2019-07-19T14:32:10.048Z] 14:32:10 INFO - GECKO(3601) | TEST DEVICES: Got loopback audio: Monitor of Null Output
[task 2019-07-19T14:32:10.050Z] 14:32:10 INFO - GECKO(3601) | TEST DEVICES: Got loopback video: Dummy video device (0x0000)
[task 2019-07-19T14:32:16.950Z] 14:32:16 INFO - GECKO(3601) | MEMORY STAT | vsize 20975030MB | residentFast 1003MB
[task 2019-07-19T14:32:16.988Z] 14:32:16 INFO - TEST-OK | dom/media/tests/mochitest/test_getUserMedia_basicScreenshare.html | took 11456ms

Comment 7

[Paul Adenot (:padenot)]

Fixed upstream, I'll re-land with the fix tomorrow.

Comment 8

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Clearing triage queue: marking P1 since it sounds like something we want this release.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5002be0f9310
Update cubeb-pulse-rs to version ee6666. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/d4c682935239
Vendor rust depencies: add ringbuf. r=kinetik

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5002be0f9310
https://hg.mozilla.org/mozilla-central/rev/d4c682935239