background-image is rendered over foreground content with transform-style: preserve-3d
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox68 | --- | unaffected |
| firefox69 | --- | fixed |
| firefox70 | --- | fixed |
People
(Reporter: mikokm, Assigned: gw)
References
(Regression)
Details
(Keywords: correctness, regression)
Attachments
(2 files)
|
646 bytes,
text/html
|
Details | |
|
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Simplified testcase attached.
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 2•5 years ago
|
||
Confirmed that disabling picture caching fixes this. I'll investigate today.
|
|
Assignee | |
Comment 3•5 years ago
|
||
The code to batch preserve-3d elements was incorrectly using the
bounds and visibility mask from the parent element. This could
result in batching bugs in some cases, which were showing up as
draw order issues.
|
||
Updated•5 years ago
|
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e77f396d5eb8 Fix bug in preserve-3d batching code in WebRender. r=nical
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 6•5 years ago
|
||
Comment on attachment 9079651 [details]
Bug 1567472 - Fix bug in preserve-3d batching code in WebRender.
Beta/Release Uplift Approval Request
- User impact if declined: Incorrect rendering in some cases for users running WebRender
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It's a very small patch (2 lines), and only affects users enrolled in WebRender.
- String changes made/needed:
|
||
Comment 7•5 years ago
|
||
Comment on attachment 9079651 [details]
Bug 1567472 - Fix bug in preserve-3d batching code in WebRender.
Fixes a rendering regression for some sites with WebRender enabled. Approved for 69.0b8.
|
||
Comment 8•5 years ago
|
||
| bugherder uplift | ||
|
||
Comment 9•5 years ago
|
||
| uplift | ||
Backed out as https://hg.mozilla.org/releases/mozilla-beta/rev/8ee010f8312a7a22626bc6f93cd03169f3ed2abd and relanded with correct commit information: https://hg.mozilla.org/releases/mozilla-beta/rev/1d05fe8447ed78f49ca0f31c7b322b1ebb11d45f
Description
•