156756 - Crash in nsComposerCommandsUpdater::CallUpdateCommands

Status: VERIFIED DUPLICATE of bug 174439

(Core Graveyard :: Embedding: APIs, defect)

Description

[Roger Chickering]

I'm embedding the editor in my app, and I found that if I created
and destroyed the window that embeds the editor very quickly, I'd
get a NULL pointer dereference on line 264 of nsComposerCommandsUpdater.cpp.

I've got a patch that fixes the problem that I'm going to check into 
the branch I'm using.  I'll attach the patch to this bug as well.

Comment 1

[Roger Chickering]

Attachment: Patch to fix the bug

I checked this patch which fixes the problem onto my branch
(ROGC_20020430_BRANCH)

Comment 2

[Kathleen :Brade]

thanks for the patch!

-->mjudge

Comment 3

[Kathleen :Brade]

Comment on attachment 90831 [details] [diff] [review]
Patch to fix the bug

r=brade
Simon--please sr=

Comment 4

[Simon Fraser [no longer active]]

Comment on attachment 90831 [details] [diff] [review]
Patch to fix the bug

sr=sfraser

Comment 5

[mjudge]

ok i am marking this invalid since we dont use scriptglobalobject on the 
embedder's side any more. This should not happen on the trunk now.

Comment 6

[Kathleen :Brade]

reopen for clarification
I don't understand what you are saying Mike but I think we still need to fix a
bug in this code.

I see this in nsComposerCommandsUpdater::CallUpdateCommands
   nsCOMPtr<nsIScriptGlobalObject> scriptGlobalObject;
   theDoc->GetScriptGlobalObject(getter_AddRefs(scriptGlobalObject));

   nsCOMPtr<nsIDocShell> docShell;
   scriptGlobalObject->GetDocShell(getter_AddRefs(docShell));
   mDocShell = docShell.get();

Are you saying that embedders can't call CallUpdateCommands?
Regardless, shouldn't we still have the safety check for scriptGlobalOject
possibly being null?

Comment 7

[Charles Manske]

The relevant code has changed in my patch to bug 174439. In that fix,
I test for the global script object and save docShell as member variable 
of nsComposerCommandsUpdater in its constructor. So we don't need this fix.

*** This bug has been marked as a duplicate of 174439 ***

Comment 8

[sujay]

verified.

Comment 9

[Kathleen :Brade]

This patch is needed on Angelo's 1.2 branch.

Comment 10

[Angelo Nunes]

Done, thanks for thinking of me ;-)