1567579 - Defer initialization of LazyScripts until after all parsing is done.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

To further our goal of decoupling the parser for the GC, we'd like to be able to avoid creating JSFunctions until after the parser is done its business.

However, we need a JSFunction to allocate a LazyScript, so this bug is about deferring the allocation of the LazyScript until after the parse is done (unblocking deferred function allocation)

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1567579 - Defer allocation of LazyScript to after parsing r?tcampbell

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1567579 - Set the toStringEnd on the lazyScript directly during construction. r?tcampbell

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1567579 - Store inner FunctionBoxes instead of inner functions r?tcampbell

This is a good preparation fo deferred function allocation (Bug 1569315),
but also removes some awkward rooting / type issues in deferred lazyscript
allocation

Depends on D39681

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1567579 - Use a FunctionBoxVector type to clarify code r?tcampbell

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc6a301ce5fc
Set the toStringEnd on the lazyScript directly during construction. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/211c315c5a40
Store inner FunctionBoxes instead of inner functions r=tcampbell

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39eba0684c1b
Use a FunctionBoxVector type to clarify code r=tcampbell

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/fc6a301ce5fc
https://hg.mozilla.org/mozilla-central/rev/211c315c5a40
https://hg.mozilla.org/mozilla-central/rev/39eba0684c1b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adac722a3dfc
Defer allocation of LazyScript to after parsing r=tcampbell

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/adac722a3dfc

Comment 10

[Ted Campbell [:tcampbell]]

Closing out this bug. There is more follow-up work on the defer-function bug but this lazy script handling is now landed.