1567605 - Add "is Admin with UAC disabled" to launcher-process-failure ping

Status: RESOLVED FIXED

(Firefox :: Launcher Process, task, P3)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This will be useful when diagnosing failures.

Comment 1

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1567605 - Add a Scalar metric to collect how many users launch a process with Admin but UAC. r=aklotz

This patch adds a new Scalar metric sandbox.is_admin_without_uac that
indicates the process is lauched with Admin privileges when UAC is turned
off.

We use the elevation type of a process token to determine UAC is on or off
instead of reading the registry value EnableLUA. Basically a token is
either full or limited if UAC is on. If the account is built-in
Administrator, however, the token type is default though UAC is on. Thus
we check the account SID as well as the elevation type.

Comment 2

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1567605 - Add is_admin_without_uac to the launcher-process-failure ping. r=aklotz

Comment 3

[Toshihito Kikuchi [:toshi]]

Attachment: data-review-request-for-bug1567605.txt

Comment 4

[Chris H-C :chutten]

Comment on attachment 9089405 [details]
data-review-request-for-bug1567605.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry and is documented in the ["launcher-process-failure" ping documentation](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/data/launcher-process-failure-ping.html)

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. (The mechanism by which this setting is communicated to the launcher process looks pretty neat, and appears to be [here](https://searchfox.org/mozilla-central/source/toolkit/xre/LauncherRegistryInfo.cpp))

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Toshihito Kikuchi and Aaron Klotz are responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels. (Windows-only)

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

This looks great, however we do have one more change that we need to make: we need to update the schema on the back-end.

You will need to clone the dev branch of this github repo and update these files with the new field, then follow the procedure for regenerating the schemas. Then check those in and submit a PR.

The process is a bit complicated but is described in the README for the repository. As always, feel free to ping me or ask questions in #telemetry on IRC.

Comment 6

[Toshihito Kikuchi [:toshi]]

Thanks, Aaron. Started https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/399

Comment 7

[Toshihito Kikuchi [:toshi]]

(In reply to Aaron Klotz [:aklotz] from comment #5)

This looks great, however we do have one more change that we need to make: we need to update the schema on the back-end.

Thanks, Aaron. The schema update has been merged into the master branch. This is ready to land.
https://github.com/mozilla-services/mozilla-pipeline-schemas/commit/603b5583ed4f725847ce24c4e594c3207b71a263

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcb214029c28
Add is_admin_without_uac to the launcher-process-failure ping. r=aklotz

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/bcb214029c28