Closed Bug 1567633 Opened 4 months ago Closed 3 months ago

High-frequency messages cause multi-second hangs

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: Harald, Assigned: tanhengyeow)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

STR:

AR:
The UI freezes for multiple seconds while messages are rendered in chunks.

Bug 1561631 might help with this somewhat, but only if the bottleneck is the amount of elements; which might not be the case.

Profile: https://perfht.ml/2YgfAh8 (tankanarchy: https://perfht.ml/2Ybjnwd)

  • React's diffProperties$1 is high, so switching some classes to pure components or using shouldComponentUpdate might reduce overhead.
  • setState takes the biggest chunk of time, so debouncing onFrameReceived (maybe using requestIdleCallback) might also free some main thread and bundle table updates.

Triggers addFrames in batches

Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/225f4a11bbb1
High-frequency messages cause multi-second hangs. r=Honza
Assignee: nobody → E0032242
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
QA Whiteboard: [qa-70b-p2]
You need to log in before you can comment on or make changes to this bug.