1567641 - Remove requirement to reject after document becomes inactive

Status: NEW

(Core :: DOM: Web Payments, defect, P5)

Description

[Marcos Caceres [:marcosc]]

Based on spec change and discussion https://github.com/w3c/payment-request/pull/875

Comment 1

[Marcos Caceres [:marcosc]]

Attachment: Remove requirement to reject after document is inactive

Recent spec change.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:marcosc, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Marcos Caceres [:marcosc]]

Yep, I need to revise this but can't right now... will sit on it for a bit longer.

Comment 4

[Jens Stutte [:jstutte]]

:marcosc, is this still needed as we do not ship Web Payments, anyway? Can we close this?

Comment 5

[Marcos Caceres [:marcosc]]

Same as the other bug... I'd like to land this just so we keep our implementation and the spec up to date. I'd try to do it in my spare time over xmas.

Comment 6

[Jens Stutte [:jstutte]]

(In reply to Marcos Caceres [:marcosc] from comment #5)

Same as the other bug... I'd like to land this just so we keep our implementation and the spec up to date. I'd try to do it in my spare time over xmas.

Hi Marcos, is there anything that prevents us from landing that patch?

Comment 7

[Marcos Caceres [:marcosc]]

(In reply to Jens Stutte [:jstutte] from comment #6)

Hi Marcos, is there anything that prevents us from landing that patch?

The patch is no quite correct :( I need to fix it, but I've not gotten time to do that yet. Will ping you on Slack with some details.

Comment 8

[Marcos Caceres [:marcosc]]

Might need to add/refactor this again in dom/payments/test/test_closePayment.html:

async function testNonfullyActivePayment() {
    const testName = "testNonfullyActivePayment";
    await requestChromeAction("test-setup", testName);
    const outer = document.createElement("iframe");
    outer.allowPaymentRequest = true;
    document.body.appendChild(outer);

    const outerRequest = await getLoadedPaymentRequest(outer);
    ok(outerRequest, `${testName}: Outer iframe request exists.`);

    const inner = outer.contentDocument.createElement("iframe");
    inner.allowPaymentRequest = true;
    outer.contentDocument.body.appendChild(inner);

    const request = await getLoadedPaymentRequest(inner);
    ok(request, `${testName}: PaymentRequest in inner iframe exist.`);

    await new Promise(res => {
      outer.onload = res;
      outer.src = "simple_payment_request.html";
    });

    outer.onload = null;

    const handler = SpecialPowers.getDOMWindowUtils(inner.contentWindow).setHandlingUserInput(true);
    try {
      const showPromise = await request.show();
      ok(false, `${testName}: expected 'AbortError', but got resolved.`);
    } catch (error) {
      is(error.name, "AbortError", `${testName}: expected 'AbortError'.`);
    }
    await handler.destruct();
    inner.remove();
    outer.remove();
  }

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Payment Request is still disabled by default, so S4.