Closed Bug 1567892 Opened 6 years ago Closed 6 years ago

Proxy check should run on the parent process

Categories

(Core :: WebRTC: Networking, defect, P1)

Product:
Core
Component:
WebRTC: Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - PProxyConfigLookup IPC protocol, r?bwc
47 bytes, text/x-phabricator-request
Details | Review

Currently, PeerConnectionMedia checks if we have to use a proxy settings for webRTC peer connections. But this check is done on the content process:
https://searchfox.org/mozilla-central/rev/b9041f813de0a05bf6de95a145d4e25004499517/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp#163-203

Because of this, if we have an extension, which uses the proxy API, this is not detected and we run webRTC without proxy. I don't think this is the only issue we have here, but definitely it's something to fix.

So, nsIProtocolProxyService doesn't work anywhere other than the parent for the plugin? If not, we need to teach it to do this. In the meantime, we could use prefs as a hack (as we discussed). If nsIProtocolProxyService cannot be fixed, maybe we will need to wrap it in a new IPDL protocol, or maybe there's some pre-existing IPDL protocol we could use (maybe we could adapt WebrtcProxyChannel).

Priority: -- → P1

I take this bug.

Assignee: nobody → amarchesini
Attachment #9079997 - Attachment description: Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - part 1 - PPeerConnectionMediaProxy IPC protocol, r?bwc → Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - part 2 - PPeerConnectionMediaProxy IPC protocol, r?bwc
Attachment #9079997 - Attachment description: Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - part 2 - PPeerConnectionMediaProxy IPC protocol, r?bwc → Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - part 2 - PProxyConfigLookup IPC protocol, r?bwc
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b1b922fe6c11 PeerConnectionMedia should use nsIProtocolProxyService on the parent process - part 1 - nsProtocolProxyService on parent process only, r=bwc,kershaw https://hg.mozilla.org/integration/autoland/rev/18a1d7fe61e0 PeerConnectionMedia should use nsIProtocolProxyService on the parent process - part 2 - PProxyConfigLookup IPC protocol, r=bwc,kershaw

Backed out 2 changesets (Bug 1567892) for build bustages complaining about PNecko.ipdl

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=18a1d7fe61e071f1d8b61a0c15d894ff4f96a3a5&tochange=b7b7644b0c596fa2fe7ebc8df2048eb165ee2670&selectedJob=258127912

Backout link: https://hg.mozilla.org/integration/autoland/rev/b7b7644b0c596fa2fe7ebc8df2048eb165ee2670

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258127912&repo=autoland&lineNumber=2454

[task 2019-07-24T15:51:28.003Z] 15:51:28 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl'
[task 2019-07-24T15:51:28.003Z] 15:51:28 INFO - /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python /builds/worker/workspace/build/src/config/pythonpath.py
[task 2019-07-24T15:51:28.003Z] 15:51:28 INFO - -I/builds/worker/workspace/build/src/other-licenses/ply
[task 2019-07-24T15:51:28.019Z] 15:51:28 INFO - /builds/worker/workspace/build/src/ipc/ipdl/ipdl.py
[task 2019-07-24T15:51:28.020Z] 15:51:28 INFO - --sync-msg-list=/builds/worker/workspace/build/src/ipc/ipdl/sync-messages.ini
[task 2019-07-24T15:51:28.020Z] 15:51:28 INFO - --msg-metadata=/builds/worker/workspace/build/src/ipc/ipdl/message-metadata.ini
[task 2019-07-24T15:51:28.020Z] 15:51:28 INFO - --outheaders-dir=_ipdlheaders
[task 2019-07-24T15:51:28.020Z] 15:51:28 INFO - --outcpp-dir=.
[task 2019-07-24T15:51:28.020Z] 15:51:28 INFO - -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl -I/builds/worker/workspace/build/src/accessible/ipc/win -I/builds/worker/workspace/build/src/devtools/shared/heapsnapshot -I/builds/worker/workspace/build/src/dom/broadcastchannel -I/builds/worker/workspace/build/src/dom/cache -I/builds/worker/workspace/build/src/dom/clients/manager -I/builds/worker/workspace/build/src/dom/fetch -I/builds/worker/workspace/build/src/dom/file/ipc -I/builds/worker/workspace/build/src/dom/filehandle -I/builds/worker/workspace/build/src/dom/filesystem -I/builds/worker/workspace/build/src/dom/gamepad/ipc -I/builds/worker/workspace/build/src/dom/indexedDB -I/builds/worker/workspace/build/src/dom/ipc -I/builds/worker/workspace/build/src/dom/localstorage -I/builds/worker/workspace/build/src/dom/media/gmp -I/builds/worker/workspace/build/src/dom/media/ipc -I/builds/worker/workspace/build/src/dom/media/systemservices -I/builds/worker/workspace/build/src/dom/media/webrtc -I/builds/worker/workspace/build/src/dom/media/webspeech/synth/ipc -I/builds/worker/workspace/build/src/dom/messagechannel -I/builds/worker/workspace/build/src/dom/midi -I/builds/worker/workspace/build/src/dom/network -I/builds/worker/workspace/build/src/dom/payments/ipc -I/builds/worker/workspace/build/src/dom/plugins/ipc -I/builds/worker/workspace/build/src/dom/presentation/ipc -I/builds/worker/workspace/build/src/dom/quota -I/builds/worker/workspace/build/src/dom/reporting -I/builds/worker/workspace/build/src/dom/serviceworkers -I/builds/worker/workspace/build/src/dom/simpledb -I/builds/worker/workspace/build/src/dom/storage -I/builds/worker/workspace/build/src/dom/webauthn -I/builds/worker/workspace/build/src/dom/webbrowserpersist -I/builds/worker/workspace/build/src/dom/workers/remoteworkers -I/builds/worker/workspace/build/src/dom/workers/sharedworkers -I/builds/worker/workspace/build/src/extensions/spellcheck/hunspell/glue -I/builds/worker/workspace/build/src/gfx/ipc -I/builds/worker/workspace/build/src/gfx/layers/ipc -I/builds/worker/workspace/build/src/gfx/vr/ipc -I/builds/worker/workspace/build/src/hal/sandbox -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/ipc/testshell -I/builds/worker/workspace/build/src/js/ipc -I/builds/worker/workspace/build/src/js/xpconnect/loader -I/builds/worker/workspace/build/src/layout/base -I/builds/worker/workspace/build/src/layout/ipc -I/builds/worker/workspace/build/src/layout/printing/ipc -I/builds/worker/workspace/build/src/netwerk/cookie -I/builds/worker/workspace/build/src/netwerk/dns -I/builds/worker/workspace/build/src/netwerk/ipc -I/builds/worker/workspace/build/src/netwerk/ipc/../../media/mtransport/ipc -I/builds/worker/workspace/build/src/netwerk/protocol/ftp -I/builds/worker/workspace/build/src/netwerk/protocol/http -I/builds/worker/workspace/build/src/netwerk/protocol/websocket -I/builds/worker/workspace/build/src/security/manager/ssl -I/builds/worker/workspace/build/src/security/sandbox/win/src/remotesandboxbroker -I/builds/worker/workspace/build/src/toolkit/components/backgroundhangmonitor -I/builds/worker/workspace/build/src/toolkit/components/extensions/webrequest -I/builds/worker/workspace/build/src/toolkit/components/printingui/ipc -I/builds/worker/workspace/build/src/tools/profiler/gecko -I/builds/worker/workspace/build/src/uriloader/exthandler -I/builds/worker/workspace/build/src/uriloader/prefetch -I/builds/worker/workspace/build/src/widget/headless -I/builds/worker/workspace/build/src/widget/windows
[task 2019-07-24T15:51:28.042Z] 15:51:28 INFO - PMediaTransport.ipdl /builds/worker/workspace/build/src/accessible/ipc/win/PDocAccessible.ipdl /builds/worker/workspace/build/src/devtools/shared/heapsnapshot/PHeapSnapshotTempFileHelper.ipdl /builds/worker/workspace/build/src/dom/broadcastchannel/PBroadcastChannel.ipdl /builds/worker/workspace/build/src/dom/cache/CacheTypes.ipdlh /builds/worker/workspace/build/src/dom/cache/PCache.ipdl /builds/worker/workspace/build/src/dom/cache/PCacheOp.ipdl /builds/worker/workspace/build/src/dom/cache/PCacheStorage.ipdl /builds/worker/workspace/build/src/dom/cache/PCacheStreamControl.ipdl /builds/worker/workspace/build/src/dom/clients/manager/ClientIPCTypes.ipdlh /builds/worker/workspace/build/src/dom/clients/manager/PClientHandle.ipdl /builds/worker/workspace/build/src/dom/clients/manager/PClientHandleOp.ipdl /builds/worker/workspace/build/src/dom/clients/manager/PClientManager.ipdl /builds/worker/workspace/build/src/dom/clients/manager/PClientManagerOp.ipdl /builds/worker/workspace/build/src/dom/clients/manager/PClientNavigateOp.ipdl /builds/worker/workspace/build/src/dom/clients/manager/PClientOpenWindowOp.ipdl /builds/worker/workspace/build/src/dom/clients/manager/PClientSource.ipdl /builds/worker/workspace/build/src/dom/clients/manager/PClientSourceOp.ipdl /builds/worker/workspace/build/src/dom/fetch/ChannelInfo.ipdlh /builds/worker/workspace/build/src/dom/fetch/FetchTypes.ipdlh /builds/worker/workspace/build/src/dom/file/ipc/BlobTypes.ipdlh /builds/worker/workspace/build/src/dom/file/ipc/IPCBlob.ipdlh /builds/worker/workspace/build/src/dom/file/ipc/PFileCreator.ipdl /builds/worker/workspace/build/src/dom/file/ipc/PIPCBlobInputStream.ipdl /builds/worker/workspace/build/src/dom/file/ipc/PPendingIPCBlob.ipdl /builds/worker/workspace/build/src/dom/file/ipc/PTemporaryIPCBlob.ipdl /builds/worker/workspace/build/src/dom/filehandle/PBackgroundFileHandle.ipdl /builds/worker/workspace/build/src/dom/filehandle/PBackgroundFileRequest.ipdl /builds/worker/workspace/build/src/dom/filehandle/PBackgroundMutableFile.ipdl /builds/worker/workspace/build/src/dom/filesystem/PFileSystemParams.ipdlh /builds/worker/workspace/build/src/dom/filesystem/PFileSystemRequest.ipdl /builds/worker/workspace/build/src/dom/gamepad/ipc/GamepadEventTypes.ipdlh /builds/worker/workspace/build/src/dom/gamepad/ipc/PGamepadEventChannel.ipdl /builds/worker/workspace/build/src/dom/gamepad/ipc/PGamepadTestChannel.ipdl /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBCursor.ipdl /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBDatabase.ipdl /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBDatabaseFile.ipdl /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBFactory.ipdl /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBFactoryRequest.ipdl /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBRequest.ipdl /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBSharedTypes.ipdlh /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBTransaction.ipdl /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBVersionChangeTransaction.ipdl /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIndexedDBUtils.ipdl /builds/worker/workspace/build/src/dom/ipc/DOMTypes.ipdlh /builds/worker/workspace/build/src/dom/ipc/MemoryReportTypes.ipdlh /builds/worker/workspace/build/src/dom/ipc/PBrowser.ipdl /builds/worker/workspace/build/src/dom/ipc/PBrowserBridge.ipdl /builds/worker/workspace/build/src/dom/ipc/PBrowserOrId.ipdlh /builds/worker/workspace/build/src/dom/ipc/PColorPicker.ipdl /builds/worker/workspace/build/src/dom/ipc/PContent.ipdl /builds/worker/workspace/build/src/dom/ipc/PContentPermission.ipdlh /builds/worker/workspace/build/src/dom/ipc/PContentPermissionRequest.ipdl /builds/worker/workspace/build/src/dom/ipc/PCycleCollectWithLogs.ipdl /builds/worker/workspace/build/src/dom/ipc/PFilePicker.ipdl /builds/worker/workspace/build/src/dom/ipc/PLoginReputation.ipdl /builds/worker/workspace/build/src/dom/ipc/PPluginWidget.ipdl /builds/worker/workspace/build/src/dom/ipc/PProcessHangMonitor.ipdl /builds/worker/workspace/build/src/dom/ipc/PTabContext.ipdlh /builds/worker/workspace/build/src/dom/ipc/PURLClassifier.ipdl /builds/worker/workspace/build/src/dom/ipc/PURLClassifierInfo.ipdlh /builds/worker/workspace/build/src/dom/ipc/PURLClassifierLocal.ipdl /builds/worker/workspace/build/src/dom/ipc/PWindowGlobal.ipdl /builds/worker/workspace/build/src/dom/ipc/PrefsTypes.ipdlh /builds/worker/workspace/build/src/dom/ipc/ServiceWorkerConfiguration.ipdlh /builds/worker/workspace/build/src/dom/localstorage/PBackgroundLSDatabase.ipdl /builds/worker/workspace/build/src/dom/localstorage/PBackgroundLSObserver.ipdl /builds/worker/workspace/build/src/dom/localstorage/PBackgroundLSRequest.ipdl /builds/worker/workspace/build/src/dom/localstorage/PBackgroundLSSharedTypes.ipdlh /builds/worker/workspace/build/src/dom/localstorage/PBackgroundLSSimpleRequest.ipdl /builds/worker/workspace/build/src/dom/localstorage/PBackgroundLSSnapshot.ipdl /builds/worker/workspace/build/src/dom/media/gmp/GMPTypes.ipdlh /builds/worker/workspace/build/src/dom/media/gmp/PChromiumCDM.ipdl /builds/worker/workspace/build/src/dom/media/gmp/PGMP.ipdl /builds/worker/workspace/build/src/dom/media/gmp/PGMPContent.ipdl /builds/worker/workspace/build/src/dom/media/gmp/PGMPService.ipdl /builds/worker/workspace/build/src/dom/media/gmp/PGMPStorage.ipdl /builds/worker/workspace/build/src/dom/media/gmp/PGMPTimer.ipdl /builds/worker/workspace/build/src/dom/media/gmp/PGMPVideoDecoder.ipdl /builds/worker/workspace/build/src/dom/media/gmp/PGMPVideoEncoder.ipdl /builds/worker/workspace/build/src/dom/media/ipc/PMediaDecoderParams.ipdlh /builds/worker/workspace/build/src/dom/media/ipc/PRDD.ipdl /builds/worker/workspace/build/src/dom/media/ipc/PRemoteDecoder.ipdl /builds/worker/workspace/build/src/dom/media/ipc/PRemoteDecoderManager.ipdl /builds/worker/workspace/build/src/dom/media/systemservices/PCameras.ipdl /builds/worker/workspace/build/src/dom/media/systemservices/PMedia.ipdl /builds/worker/workspace/build/src/dom/media/systemservices/PMediaSystemResourceManager.ipdl /builds/worker/workspace/build/src/dom/media/webrtc/PWebrtcGlobal.ipdl /builds/worker/workspace/build/src/dom/media/webspeech/synth/ipc/PSpeechSynthesis.ipdl /builds/worker/workspace/build/src/dom/media/webspeech/synth/ipc/PSpeechSynthesisRequest.ipdl /builds/worker/workspace/build/src/dom/messagechannel/PMessagePort.ipdl /builds/worker/workspace/build/src/dom/midi/MIDITypes.ipdlh /builds/worker/workspace/build/src/dom/midi/PMIDIManager.ipdl /builds/worker/workspace/build/src/dom/midi/PMIDIPort.ipdl /builds/worker/workspace/build/src/dom/network/PTCPServerSocket.ipdl /builds/worker/workspace/build/src/dom/network/PTCPSocket.ipdl /builds/worker/workspace/build/src/dom/network/PUDPSocket.ipdl /builds/worker/workspace/build/src/dom/payments/ipc/PPaymentRequest.ipdl /builds/worker/workspace/build/src/dom/plugins/ipc/PBrowserStream.ipdl /builds/worker/workspace/build/src/dom/plugins/ipc/PFunctionBroker.ipdl /builds/worker/workspace/build/src/dom/plugins/ipc/PPluginBackgroundDestroyer.ipdl /builds/worker/workspace/build/src/dom/plugins/ipc/PPluginInstance.ipdl /builds/worker/workspace/build/src/dom/plugins/ipc/PPluginModule.ipdl /builds/worker/workspace/build/src/dom/plugins/ipc/PPluginScriptableObject.ipdl /builds/worker/workspace/build/src/dom/plugins/ipc/PPluginSurface.ipdl /builds/worker/workspace/build/src/dom/plugins/ipc/PStreamNotify.ipdl /builds/worker/workspace/build/src/dom/plugins/ipc/PluginTypes.ipdlh /builds/worker/workspace/build/src/dom/presentation/ipc/PPresentation.ipdl /builds/worker/workspace/build/src/dom/presentation/ipc/PPresentationBuilder.ipdl /builds/worker/workspace/build/src/dom/presentation/ipc/PPresentationRequest.ipdl /builds/worker/workspace/build/src/dom/quota/PQuota.ipdl /builds/worker/workspace/build/src/dom/quota/PQuotaRequest.ipdl /builds/worker/workspace/build/src/dom/quota/PQuotaUsageRequest.ipdl /builds/worker/workspace/build/src/dom/reporting/PEndpointForReport.ipdl /builds/worker/workspace/build/src/dom/serviceworkers/IPCServiceWorkerDescriptor.ipdlh /builds/worker/workspace/build/src/dom/serviceworkers/IPCServiceWorkerRegistrationDescriptor.ipdlh /builds/worker/workspace/build/src/dom/serviceworkers/PServiceWorker.ipdl /builds/worker/workspace/build/src/dom/serviceworkers/PServiceWorkerContainer.ipdl /builds/worker/workspace/build/src/dom/serviceworkers/PServiceWorkerManager.ipdl /builds/worker/workspace/build/src/dom/serviceworkers/PServiceWorkerRegistration.ipdl /builds/worker/workspace/build/src/dom/serviceworkers/PServiceWorkerUpdater.ipdl /builds/worker/workspace/build/src/dom/serviceworkers/ServiceWorkerRegistrarTypes.ipdlh /builds/worker/workspace/build/src/dom/simpledb/PBackgroundSDBConnection.ipdl /builds/worker/workspace/build/src/dom/simpledb/PBackgroundSDBRequest.ipdl /builds/worker/workspace/build/src/dom/storage/PBackgroundLocalStorageCache.ipdl /builds/worker/workspace/build/src/dom/storage/PBackgroundStorage.ipdl /builds/worker/workspace/build/src/dom/storage/PSessionStorageObserver.ipdl /builds/worker/workspace/build/src/dom/webauthn/PWebAuthnTransaction.ipdl /builds/worker/workspace/build/src/dom/webbrowserpersist/PWebBrowserPersistDocument.ipdl /builds/worker/workspace/build/src/dom/webbrowserpersist/PWebBrowserPersistResources.ipdl /builds/worker/workspace/build/src/dom/webbrowserpersist/PWebBrowserPersistSerialize.ipdl /builds/worker/workspace/build/src/dom/workers/remoteworkers/PRemoteWorker.ipdl /builds/worker/workspace/build/src/dom/workers/remoteworkers/PRemoteWorkerService.ipdl /builds/worker/workspace/build/src/dom/workers/remoteworkers/RemoteWorkerTypes.ipdlh /builds/worker/workspace/build/src/dom/workers/sharedworkers/PSharedWorker.ipdl /builds/worker/workspace/build/src/extensions/spellcheck/hunspell/glue/PRemoteSpellcheckEngine.ipdl /builds/worker/workspace/build/src/gfx/ipc/GraphicsMessages.ipdlh /builds/worker/workspace/build/src/gfx/ipc/PGPU.ipdl /builds/worker/workspace/build/src/gfx/ipc/PVsyncBridge.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/LayersMessages.ipdlh /builds/worker/workspace/build/src/gfx/layers/ipc/LayersSurfaces.ipdlh /builds/worker/workspace/build/src/gfx/layers/ipc/PAPZ.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/PAPZCTreeManager.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/PAPZInputBridge.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/PCanvas.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/PCompositorBridge.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/PCompositorManager.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/PImageBridge.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/PLayerTransaction.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/PTexture.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/PUiCompositorController.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/PVideoBridge.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/PWebRenderBridge.ipdl /builds/worker/workspace/build/src/gfx/layers/ipc/WebRenderMessages.ipdlh /builds/worker/workspace/build/src/gfx/vr/ipc/PVR.ipdl /builds/worker/workspace/build/src/gfx/vr/ipc/PVRGPU.ipdl /builds/worker/workspace/build/src/gfx/vr/ipc/PVRLayer.ipdl /builds/worker/workspace/build/src/gfx/vr/ipc/PVRManager.ipdl /builds/worker/workspace/build/src/hal/sandbox/PHal.ipdl /builds/worker/workspace/build/src/ipc/glue/IPCStream.ipdlh /builds/worker/workspace/build/src/ipc/glue/InputStreamParams.ipdlh /builds/worker/workspace/build/src/ipc/glue/PBackground.ipdl /builds/worker/workspace/build/src/ipc/glue/PBackgroundSharedTypes.ipdlh /builds/worker/workspace/build/src/ipc/glue/PBackgroundTest.ipdl /builds/worker/workspace/build/src/ipc/glue/PChildToParentStream.ipdl /builds/worker/workspace/build/src/ipc/glue/PFileDescriptorSet.ipdl /builds/worker/workspace/build/src/ipc/glue/PInProcess.ipdl /builds/worker/workspace/build/src/ipc/glue/PParentToChildStream.ipdl /builds/worker/workspace/build/src/ipc/glue/ProtocolTypes.ipdlh /builds/worker/workspace/build/src/ipc/glue/URIParams.ipdlh /builds/worker/workspace/build/src/ipc/testshell/PTestShell.ipdl /builds/worker/workspace/build/src/ipc/testshell/PTestShellCommand.ipdl /builds/worker/workspace/build/src/js/ipc/JavaScriptTypes.ipdlh /builds/worker/workspace/build/src/js/ipc/PJavaScript.ipdl /builds/worker/workspace/build/src/js/xpconnect/loader/PScriptCache.ipdl /builds/worker/workspace/build/src/layout/base/PresState.ipdlh /builds/worker/workspace/build/src/layout/ipc/PVsync.ipdl /builds/worker/workspace/build/src/layout/printing/ipc/PRemotePrintJob.ipdl /builds/worker/workspace/build/src/netwerk/cookie/PCookieService.ipdl /builds/worker/workspace/build/src/netwerk/dns/PDNSRequest.ipdl /builds/worker/workspace/build/src/netwerk/dns/PDNSRequestParams.ipdlh /builds/worker/workspace/build/src/netwerk/ipc/../../media/mtransport/ipc/PStunAddrsRequest.ipdl /builds/worker/workspace/build/src/netwerk/ipc/../../media/mtransport/ipc/PWebrtcProxyChannel.ipdl /builds/worker/workspace/build/src/netwerk/ipc/NeckoChannelParams.ipdlh /builds/worker/workspace/build/src/netwerk/ipc/PChannelDiverter.ipdl /builds/worker/workspace/build/src/netwerk/ipc/PDataChannel.ipdl /builds/worker/workspace/build/src/netwerk/ipc/PFileChannel.ipdl /builds/worker/workspace/build/src/netwerk/ipc/PNecko.ipdl /builds/worker/workspace/build/src/netwerk/ipc/PSimpleChannel.ipdl /builds/worker/workspace/build/src/netwerk/ipc/PSocketProcess.ipdl /builds/worker/workspace/build/src/netwerk/ipc/PSocketProcessBridge.ipdl /builds/worker/workspace/build/src/netwerk/protocol/ftp/PFTPChannel.ipdl /builds/worker/workspace/build/src/netwerk/protocol/http/PAltDataOutputStream.ipdl /builds/worker/workspace/build/src/netwerk/protocol/http/PClassifierDummyChannel.ipdl /builds/worker/workspace/build/src/netwerk/protocol/http/PHttpBackgroundChannel.ipdl /builds/worker/workspace/build/src/netwerk/protocol/http/PHttpChannel.ipdl /builds/worker/workspace/build/src/netwerk/protocol/websocket/PTransportProvider.ipdl /builds/worker/workspace/build/src/netwerk/protocol/websocket/PWebSocket.ipdl /builds/worker/workspace/build/src/netwerk/protocol/websocket/PWebSocketEventListener.ipdl /builds/worker/workspace/build/src/security/manager/ssl/PPSMContentDownloader.ipdl /builds/worker/workspace/build/src/security/sandbox/win/src/remotesandboxbroker/PRemoteSandboxBroker.ipdl /builds/worker/workspace/build/src/toolkit/components/backgroundhangmonitor/HangTypes.ipdlh /builds/worker/workspace/build/src/toolkit/components/extensions/webrequest/PStreamFilter.ipdl /builds/worker/workspace/build/src/toolkit/components/printingui/ipc/PPrintProgressDialog.ipdl /builds/worker/workspace/build/src/toolkit/components/printingui/ipc/PPrintSettingsDialog.ipdl /builds/worker/workspace/build/src/toolkit/components/printingui/ipc/PPrinting.ipdl /builds/worker/workspace/build/src/toolkit/components/printingui/ipc/PPrintingTypes.ipdlh /builds/worker/workspace/build/src/tools/profiler/gecko/PProfiler.ipdl /builds/worker/workspace/build/src/tools/profiler/gecko/ProfilerTypes.ipdlh /builds/worker/workspace/build/src/uriloader/exthandler/PExternalHelperApp.ipdl /builds/worker/workspace/build/src/uriloader/exthandler/PHandlerService.ipdl /builds/worker/workspace/build/src/uriloader/prefetch/POfflineCacheUpdate.ipdl /builds/worker/workspace/build/src/widget/headless/HeadlessWidgetTypes.ipdlh /builds/worker/workspace/build/src/widget/windows/PCompositorWidget.ipdl /builds/worker/workspace/build/src/widget/windows/PlatformWidgetTypes.ipdlh
[task 2019-07-24T15:51:28.043Z] 15:51:28 INFO - in file included from /builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/PMediaTransport.ipdl', line 5: [task 2019-07-24T15:51:28.043Z] 15:51:28 INFO - in file included from/builds/worker/workspace/build/src/ipc/glue/PBackground.ipdl', line 5:
[task 2019-07-24T15:51:28.043Z] 15:51:28 INFO - in file included from /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6: [task 2019-07-24T15:51:28.043Z] 15:51:28 INFO - in file included from/builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
[task 2019-07-24T15:51:28.043Z] 15:51:28 INFO - in file included from /builds/worker/workspace/build/src/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6: [task 2019-07-24T15:51:28.043Z] 15:51:28 INFO - in file included from/builds/worker/workspace/build/src/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
[task 2019-07-24T15:51:28.043Z] 15:51:28 INFO - in file included from /builds/worker/workspace/build/src/dom/filehandle/PBackgroundFileHandle.ipdl', line 5: [task 2019-07-24T15:51:28.043Z] 15:51:28 INFO - in file included from/builds/worker/workspace/build/src/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
[task 2019-07-24T15:51:28.044Z] 15:51:28 INFO - in file included from /builds/worker/workspace/build/src/dom/file/ipc/PPendingIPCBlob.ipdl', line 7: [task 2019-07-24T15:51:28.044Z] 15:51:28 INFO - in file included from/builds/worker/workspace/build/src/dom/file/ipc/IPCBlob.ipdlh', line 5:
[task 2019-07-24T15:51:28.044Z] 15:51:28 INFO - in file included from /builds/worker/workspace/build/src/ipc/glue/PChildToParentStream.ipdl', line 6: [task 2019-07-24T15:51:28.044Z] 15:51:28 INFO - in file included from/builds/worker/workspace/build/src/dom/ipc/PContent.ipdl', line 13:
[task 2019-07-24T15:51:28.044Z] 15:51:28 INFO - in file included from /builds/worker/workspace/build/src/security/manager/ssl/PPSMContentDownloader.ipdl', line 7: [task 2019-07-24T15:51:28.045Z] 15:51:28 INFO - in file included from/builds/worker/workspace/build/src/netwerk/ipc/PChannelDiverter.ipdl', line 7:
[task 2019-07-24T15:51:28.045Z] 15:51:28 INFO - in file included from /builds/worker/workspace/build/src/netwerk/protocol/ftp/PFTPChannel.ipdl', line 8: [task 2019-07-24T15:51:28.045Z] 15:51:28 ERROR - /builds/worker/workspace/build/src/netwerk/ipc/PNecko.ipdl:31: error: can't locate include filePProxyConfigLookup.ipdl'
[task 2019-07-24T15:51:28.046Z] 15:51:28 INFO - Specification could not be parsed.
[task 2019-07-24T15:51:28.046Z] 15:51:28 INFO - Makefile:34: recipe for target 'ipdl.track' failed
[task 2019-07-24T15:51:28.047Z] 15:51:28 ERROR - make[4]: *** [ipdl.track] Error 1
[task 2019-07-24T15:51:28.047Z] 15:51:28 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl'
[task 2019-07-24T15:51:28.047Z] 15:51:28 INFO - /builds/worker/workspace/build/src/config/recurse.mk:101: recipe for target 'ipc/ipdl/export' failed
[task 2019-07-24T15:51:28.047Z] 15:51:28 ERROR - make[3]: *** [ipc/ipdl/export] Error 2
[task 2019-07-24T15:51:28.047Z] 15:51:28 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2019-07-24T15:51:28.091Z] 15:51:28 INFO - make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/config/makefiles/xpidl'

Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3aef1ee02e9b PeerConnectionMedia should use nsIProtocolProxyService on the parent process - part 1 - nsProtocolProxyService on parent process only, r=bwc,kershaw https://hg.mozilla.org/integration/autoland/rev/edcdfaa8a2b1 PeerConnectionMedia should use nsIProtocolProxyService on the parent process - part 2 - PProxyConfigLookup IPC protocol, r=bwc,kershaw

(In reply to Andreea Pavel [:apavel] from comment #10)

There is also the following assertion failure https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258242706&repo=autoland&lineNumber=23093

This is actually a good news. It means that the assertion is detecting what we want. I would work on this as a follow up.
We can land the second patch only for this bug.

Flags: needinfo?(amarchesini)
Attachment #9079996 - Attachment is obsolete: true
Attachment #9079997 - Attachment description: Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - part 2 - PProxyConfigLookup IPC protocol, r?bwc → Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - PProxyConfigLookup IPC protocol, r?bwc
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/de98fc620593 PeerConnectionMedia should use nsIProtocolProxyService on the parent process - PProxyConfigLookup IPC protocol, r=bwc,kershaw,jld

https://hg.mozilla.org/mozilla-central/rev/de98fc620593

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
See Also: → 1570637
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: