1567900 - browser.proxy.onRequest.addListener() doesn't receive FTP requests if 'requestHeaders' is used as extraInfoSpec.

Status: NEW

(WebExtensions :: General, defect, P3)

Description

[Andrea Marchesini [:baku]]

Maybe this is the desired behavior, but, if 'requestHeaders' is used as extraInfoSpec, FTP requests are not received by the extension because of this:

https://searchfox.org/mozilla-central/rev/b9041f813de0a05bf6de95a145d4e25004499517/toolkit/components/extensions/webrequest/ChannelWrapper.cpp#324-325

Probably it's better to remove these 2 lines, and pass an empty array as requestHeaders.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Or dont use it with non-http channels here...

https://searchfox.org/mozilla-central/rev/b9041f813de0a05bf6de95a145d4e25004499517/toolkit/components/extensions/ProxyScriptContext.jsm#418

Since a workaround is to just use a second listener for ftp that doesn't ask for requestheaders, giving this a low priority.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

FTP support has been removed (bug 1574475) but it seems like this bug concerns any non-http protocols.